1836051 - URL text is selected when switching from a loaded tab and not selected when switching from a new tab

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect)

Description

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: tab_switch.gif

• noticed in bug 1834218 comment 14

Found in

• 115.0a1

Affected versions

• 115.0a1 (2023-05-31)
• 114.0RC2
• 113.0.2

Tested platforms

• Affected platforms: Windows10 x64, Ubuntu 20.04, macOS 12
• Unaffected platforms: none

Preconditions

• new profile
• have a random webpage loaded in a new tab
• have a new tab opened with an empty URL bar

Steps to reproduce

1. Open a new tab and type a random text inside the URL bar.
2. Switch to the tab that has the loaded webpage and back and observe the URL bar.
3. Switch to the new tab with the empty URL bar and back and observe the URL bar.

Expected result

• Switching from a new tab or a loaded tab back to the tab that contains the text behaves the same.

Actual result

• switching from a loaded tab will select the text inside the URL bar
• switching from a new tab will not select the text and will move the caret to the left side

Regression range

• Reproduced with Firefox 111.0a1 (2023-02-02) as well. I will search for one ASAP if there is one.

Additional notes

• Attached a screen recording.

Comment 1

[Kestrel]

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=d1c5e3749ee46b179801c5d3e1ab15fd7c77a400&tochange=4cef8491818d39b729267a6ccd09ba517311726e

Regressed by Bug 1565751.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1565751

:daisuke, since you are the author of the regressor, bug 1565751, could you take a look?

For more information, please visit BugBot documentation.

Comment 3

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1836051: Make the original URLbar to revert its previous focus state when switching tabs

Comment 4

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1836051: Make the original URLbar to revert its previous focus state when switching tabs

Comment 5

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1836051: Make the original URLbar to revert its previous focus state when switching tabs

Comment 6

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1836051: Make the urlbar to revert its previous focus state when switching tabs

Comment 7

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1836051: Restore selection range when tab switching

Depends on D180266

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b15e56c19bb7
Make the urlbar to revert its previous focus state when switching tabs r=tabbrowser-reviewers,dao
https://hg.mozilla.org/integration/autoland/rev/1b340c6a4e28
Restore selection range when tab switching r=tabbrowser-reviewers,mconley

Comment 9

[Atila Butkovits]

Backed out for causing failures at browser_keepStateAcrossTabSwitches.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/d242be9ed14eaa1cbe26517c0aaa51a1c3720d00

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=cZRjHtYKQjutWhKUAHrPTQ.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=1b340c6a4e28871fce7c4c93f6fca37846580be8

Failure log:
https://treeherder.mozilla.org/logviewer?job_id=419285143&repo=autoland&lineNumber=7083

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7ccb930352bf
Make the urlbar to revert its previous focus state when switching tabs r=tabbrowser-reviewers,dao
https://hg.mozilla.org/integration/autoland/rev/513f9d3ebb82
Restore selection range when tab switching r=tabbrowser-reviewers,mconley

Comment 11

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/7ccb930352bf
https://hg.mozilla.org/mozilla-central/rev/513f9d3ebb82

Comment 12

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:daisuke, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox115 to wontfix.

For more information, please visit BugBot documentation.

Comment 13

[Daisuke Akatsuka (:daisuke)]

Comment on attachment 9337948 [details]
Bug 1836051: Make the urlbar to revert its previous focus state when switching tabs

Beta/Release Uplift Approval Request

• User impact if declined: When user selects a tab, the text on the urlbar is selected or not depending on the condition.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This change affects only tab switching.
• String changes made/needed: None
• Is Android affected?: Unknown

Comment 14

[Donal Meehan [:dmeehan]]

Comment on attachment 9337948 [details]
Bug 1836051: Make the urlbar to revert its previous focus state when switching tabs

Approved for 115.0b8.

Comment 15

[Donal Meehan [:dmeehan]]

Comment on attachment 9338233 [details]
Bug 1836051: Restore selection range when tab switching

Approved for 115.0b8.

Comment 16

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/97c1c2d6b026
https://hg.mozilla.org/releases/mozilla-beta/rev/0ab0083705d4

Comment 17

[Vlad Lucaci, Thunderbird QA (:vlucaci)]

Hello,

Confirming this issue as verified fixed on 115.0b8(20230620180051) and 116.0a1(20230621040008).
Verified using macOS 13.1, Ubuntu 22 and Windows 11.