1836185 - UnknownCollectionError: Unknown Collection "thunderbird/translations-models"

Status: NEW

(Thunderbird :: General, defect)

Description

[Magnus Melin [:mkmelin] (away, back June 30)]

+++ This bug was initially created as a clone of Bug #1830216 +++

I've started getting this spew showing up in the console for my builds:

UnknownCollectionError: Unknown Collection "thunderbird/translations-models"
UnknownCollectionError resource://services-settings/RemoteSettingsClient.sys.mjs:192
sync resource://services-settings/RemoteSettingsClient.sys.mjs:616
RemoteSettingsClient.sys.mjs:532:15
get resource://services-settings/RemoteSettingsClient.sys.mjs:532
Translations: Error: Unable to retrieve the translation models.
#getTranslationModelRecords resource://gre/actors/TranslationsParent.sys.mjs:887
TranslationsChild.sys.mjs:520:66
handleEvent resource://gre/actors/TranslationsChild.sys.mjs:520

Comment 1

[Magnus Melin [:mkmelin] (away, back June 30)]

Apparently no main/translations-models.json dump is shipped with Firefox, like RemoteSettings normally do. Is this intentional?
E.g. anti-tracking-url-decoration.json

Comment 2

[Erik Nordin [:nordzilla]]

Thank you for pinging me on this.

I was not aware new RemoteSettings collections would have any effect on Thunderbird. None of this code, such as TranslationsParent.sys.mjs is intended to be used in Thunderbird at this time, so I definitely need to figure out how to ensure that it doesn't affect Thunderbird.

I'm leaving NI open to remind myself to look into this next week.

Comment 3

[Erik Nordin [:nordzilla]]

I believe that this is a result of this:

https://bugzilla.mozilla.org/show_bug.cgi?id=1831963

We recently enabled the translations pref for nightly/early beta.

I think this should have been enabled for only browser and not all of toolkit.

Are these errors actively blocking Thunderbird compilation, or just adding noise?

Comment 4

[Magnus Melin [:mkmelin] (away, back June 30)]

It's just console noise, not causing any further harm afaik.

Regarding RemoteSettings - so Thunderbird technically uses the RemoteSettings system, since there is too much code depending on it. We don't actively use it to change any settings atm though. Thunderbird has its own server for settings, and the "main" bucket is pointed to a "thunderbird" bucket instead.

We can flip the pref, but of course the translations project is something that will be a pretty awesome feature to use inside Thunderbird once it's finished - so it could be beneficial to keep it enabled even if not exposed anywhere.

Anyway, the question remains - why isn't a translations-models.json dump shipped with Firefox?
If we just ship something (minimal) the console errors should go away too.

Comment 5

[Greg Tatum [:gregtatum]]

This made me realize I did the pref wrong, and should have put the enable in firefox.js rather than all.js. I have Bug 1836503 to fix this.

We can flip the pref, but of course the translations project is something that will be a pretty awesome feature to use inside Thunderbird once it's finished - so it could be beneficial to keep it enabled even if not exposed anywhere.

Feel free to enable it in the thunderbird prefs!

Anyway, the question remains - why isn't a translations-models.json dump shipped with Firefox?

I need to look into having the json dump shipped, and verify we can do it without the attachments. That would definitely remove several error cases. I honestly hadn't thought about that.

Comment 6

[Magnus Melin [:mkmelin] (away, back June 30)]

So atm this isn't causing a problem since we don't yet have browser.translations.enable set in all-thunderbird.js
After we do, I expect we need to copy the dumps from https://hg.mozilla.org/mozilla-central/rev/379da4a3c107 as well.