1836986 - Hide tags field in the Star ("Bookmark this page") panel when the user has no tags

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, enhancement, P3)

Description

[Dão Gottwald [:dao]]

Tags are a nice power user feature, but most people won't need or want them, so let's hide the tags field from the Star panel when the user hasn't tagged any bookmarks. For existing users of tags this means no change. Users who don't have any tags but want to opt into the feature can do so in the full Edit Bookmark dialog or the Library window.

Comment 1

[Marco Bonardo [:mak]]

The scope of the bug is to show/hide the tags field depending on whether the user has ANY tags, so the first time the star dialog is shown we must use bookmarks.fetchTags to check if the user has any tags, and cache that information somewhere in browser-places.js. It may be in a boolean property maybe.
After that point, if the result is FALSE (no tags) we must keep this cached result up-to-date, in case the user adds a tag later. We can use the already existing PlacesObserver (handleEvent) implementation in browser-places, and detect when the user is adding a tag, then flip the boolean.
This avoids roundtrip to the database every time the dialog is opened.

Comment 2

[Karandeep Lubana [:klubana]]

Attachment: Bug 1836986 - Hide tags field in the Star ("Bookmark this page") panel when the user has no tags. r?dao

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a529a3830f68
Hide tags field in the Star ("Bookmark this page") panel when the user has no tags. r=dao,mak

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/a529a3830f68

Comment 5

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Confirming this enhancement is implemented on Firefox 116.0b2(build ID: 20230706193912) and Nightly 117.0a1(build ID: 20230707092800) on macOS 12, Windows 11, Ubuntu 22.