1464580 - Make tags and folder selection a subview

Status: NEW

(Firefox :: Bookmarks & History, enhancement, P3)

Comment 1

[Tim Nguyen :ntim]

Attachment: Bug 1464580 - WIP

Review commit: https://reviewboard.mozilla.org/r/247054/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/247054/

Comment 4

[Jeff Fortin]

While making these widgets a subview could help with the "Save button is hidden by the scrolling area" problem, another (complementary, and potentially much simpler) approach would be to just not show the thumbnail widget, because it eats humongous amounts of vertical space for apparently no real purpose; see bug #1820398 (I don't seem to be able to add it as a "see also" metadata item in here).

The reason I'm pointing this out here is that any bug report on vertical space issues with the bookmark creation popover, such as #1634683, get marked a duplicate of this subviews issue here, but I think it's not the only thing that can/must be done to make this popover space-efficient on laptop screens.

Comment 5

[Stephanie Cunnane [:scunnane]]

In the bookmark editing dialog, it's growing vertically when you click the Location and/or Tags dropdown. The idea proposed is to add a subview instead.

We should coordinate with UX to check that we'd still like to make this change.

Comment 6

[Josh Berman]

Could someone elaborate on the problem/issue we are trying to solve. I'm not sure I understand from the Bug title and conversation here.

Comment 7

[Stephanie Cunnane [:scunnane]]

Attachment: bookmarks_popover.png

Comment 8

[Stephanie Cunnane [:scunnane]]

Attachment: subview.gif

Comment 9

[Stephanie Cunnane [:scunnane]]

For reference, to see a subview, open the hamburger menu and click on anything with the > sign. A subview slides in from the side. (See the attached subview.gif)

However, per Dao, there's an ongoing initiative exploring more radical changes to this UI (beyond bug 1836986). (For details, see the #experiment-bookmarks Slack channel.) Engineering and UX should probably not spend time on making these subviews before we have results from that initiative.