1837236 - Port bug 1824799: Let the about:home startup cache ride the trains out from Nightly

Status: RESOLVED FIXED

(Thunderbird :: Upstream Synchronization, task)

Description

[Rob Lemley [:rjl]]

TEST-UNEXPECTED-FAIL | toolkit/components/featuregates/test/unit/test_FeatureGate.js | testAllDefaultsMatchSettings - [testAllDefaultsMatchSettings : 439] Feature browser.startup.homepage.abouthome_cache.enabled should match runtime value. - true == false

Apparently it's not used in Thunderbird, nevertheless we have a pref that's not jiving with what a test expects and is causing permafail on 115.0beta1.

// Not used in Thunderbird.
#ifdef NIGHTLY_BUILD
pref("browser.startup.homepage.abouthome_cache.enabled", true);
#else
pref("browser.startup.homepage.abouthome_cache.enabled", false);
#endif

Comment 1

[Rob Lemley [:rjl]]

Attachment: Bug 1837236 - Port bug 1824799: Always enable about:home startup cache. r=#thunderbird-reviewers

Fix for permafail on beta.

Comment 2

[Rob Lemley [:rjl]]

Comment on attachment 9337911 [details]
Bug 1837236 - Port bug 1824799: Always enable about:home startup cache. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta - fix permafail orange test. Per comment, enabling this pref doesn't affect Thunderbird as it's "Not used". I confirmed that it's for a browser-only component.. why the test is in toolkit makes no sense though...

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/7f5449712248
Port bug 1824799: Always enable about:home startup cache. r=freaktechnik

Comment 4

[Rob Lemley [:rjl]]

Thunderbird 115.0b1:
https://hg.mozilla.org/releases/comm-beta/rev/e7e5fd5289cf