1837594 - Empty unified toolbar customization preview target has no height

Status: RESOLVED FIXED

(Thunderbird :: Toolbars and Tabs, defect)

Description

[Martin Giger [:freaktechnik]]

Attachment: screenshot.png

STR:

• Open unified toolbar customization
• Remove all contents

Expected result:
The toolbar height stays about the same

Actual result:
The toolbar contents collapse, even after removing any button/search field and just being left with spacers.

Comment 1

[Martin Giger [:freaktechnik]]

Attachment: Bug 1837594 - Try to keep unified toolbar customization preview area constant height. r=#thunderbird-front-end-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/78759bbc981b
Try to keep unified toolbar customization preview area constant height. r=aleca

Comment 3

[Martin Giger [:freaktechnik]]

Comment on attachment 9338242 [details]
Bug 1837594 - Try to keep unified toolbar customization preview area constant height. r=#thunderbird-front-end-reviewers

[Approval Request Comment]
Regression caused by (bug #): bug 1837441
User impact if declined: Removing all buttons/search bars from the toolbar preview makes the toolbar really short (making it hard to interact with it)
Testing completed (on c-c, etc.): Manually tested on c-c
Risk to taking this patch (and alternatives if risky): Low (styles only)

Comment 4

[Wayne Mery (:wsmwk)]

Comment on attachment 9338242 [details]
Bug 1837594 - Try to keep unified toolbar customization preview area constant height. r=#thunderbird-front-end-reviewers

[Triage Comment]
Approved for beta

Comment 5

[Daniel Darnell [:dandarnell]]

Thunderbird 115.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/e244b5d707ba