1838389 - NullPointerException: Attempt to invoke virtual method 'java.lang.String java.lang.Object.toString()' on a null object reference

Status: VERIFIED FIXED

(Fenix :: Crash Reporting, defect, P2)

Description

[Rahul Sainani [:rsainani]]

Sentry crash report.

Starting 116, there have been increasing number of crashes in the CrashReporter. There are different android os versions and locales, seems like an issue in the CrashReporter.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:royang, could you have a look please?

For more information, please visit BugBot documentation.

Comment 2

[Roger Yang [:royang]]

Looks like these crashes occurred around the same time when Nightly was crashing on start https://bugzilla.mozilla.org/show_bug.cgi?id=1837869.
This is probably because of large number of users trying to report the crash.

That said, we should still figure out which string is null when crash reporter trying to send the crash report.

Comment 3

[Chris Peterson [:cpeterson]]

Marking this bug as a regression in 116.

We have not crash reports from Fenix Release. Why does this crash only affect Nightly and Beta? Does the crash reporter do something different in Nightly and Beta?

Stack track from Sentry:

https://mozilla.sentry.io/issues/4263268818/?query=is%3Aunresolved+Object.toString&referrer=issue-stream&statsPeriod=14d&stream_index=0

java.lang.String in valueOf at line 3657
java.lang.StringBuilder in append at line 132
java.lang.Throwable in printEnclosedStackTrace at line 717
java.lang.Throwable in printStackTrace at line 682
java.lang.Throwable in printStackTrace at line 743
mozilla.components.support.base.ext.ThrowableKt in getStacktraceAsString$default at line 19
mozilla.components.lib.crash.service.MozillaSocorroService in sendCrashData at line 607
mozilla.components.lib.crash.service.MozillaSocorroService in sendReport$lib_crash_release at line 285
mozilla.components.lib.crash.service.MozillaSocorroService in report at line 5
mozilla.components.lib.crash.CrashReporter$submitReport$2 in invokeSuspend at line 70
kotlin.coroutines.jvm.internal.BaseContinuationImpl in resumeWith at line 9
kotlinx.coroutines.DispatchedTask in run at line 112
kotlinx.coroutines.internal.LimitedDispatcher$Worker in run at line 4
kotlinx.coroutines.scheduling.TaskImpl in run at line 3
kotlinx.coroutines.scheduling.CoroutineScheduler$Worker in run at line 96

Comment 4

[[:skhan]]

This is being highly affected in release as well : Attaching sentry report
https://mozilla.sentry.io/issues/4263268818/?project=6295546&query=is%3Aunresolved+Object.toString&referrer=issue-stream&statsPeriod=14d&stream_index=0

Comment 5

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1838389 - Catch NullPointerException while printStackTrace (#3063)

Comment 6

[BMO Github Automation]

Authored by https://github.com/rocketsroger
https://github.com/mozilla-mobile/firefox-android/commit/884a6086756fd35320e49a9d80768a646492477c
[main] Bug 1838389 - Catch NullPointerException while printStackTrace

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:royang, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox117 to wontfix.

For more information, please visit BugBot documentation.

Comment 8

[Rob Wu [:robwu]]

FYI: I verified the presence of the bug in Beta and the resolution of the issue on Nightly, using the STR from bug 1847372 to trigger this crash.

Since this issue endangers the quality of crash reporting, I recommend an uplift.

On the other hand, if the resulting stack traces are still annotated with "[@ EMPTY: no frame data available ]" as seen at https://bugzilla.mozilla.org/show_bug.cgi?id=1847372#c4, the automatic aggregation is not as helpful as it could be. Someone who finds the crash report in about:crashes can still share the Socorro link, so there is at least some non-zero value in these reports though.

Comment 9

[Roger Yang [:royang]]

Comment on attachment 9346587 [details] [review]
[mozilla-mobile/firefox-android] Bug 1838389 - Catch NullPointerException while printStackTrace (#3063)

Beta/Release Uplift Approval Request

• User impact if declined: Crash when trying to report crashes
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is only to catch a crash that happens during crash reporting.
• String changes made/needed:
• Is Android affected?: Yes

Comment 10

[Roger Yang [:royang]]

Comment on attachment 9346587 [details] [review]
[mozilla-mobile/firefox-android] Bug 1838389 - Catch NullPointerException while printStackTrace (#3063)

Beta/Release Uplift Approval Request

• User impact if declined: Crash when trying to report crashes
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is only to catch a crash that happens during crash reporting.
• String changes made/needed:
• Is Android affected?: Yes

Comment 11

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1838389 - Catch NullPointerException while printStackTrace (backport #3063) (#3187)

Comment 12

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1838389 - Catch NullPointerException while printStackTrace (backport #3063) (#3188)

Comment 13

[Dianna Smith [:diannaS]]

Comment on attachment 9348225 [details] [review]
[mozilla-mobile/firefox-android] Bug 1838389 - Catch NullPointerException while printStackTrace (backport #3063) (#3187)

Approved for Mobile 117.0b6

Comment 14

[BMO Github Automation]

Authored by https://github.com/mergify[bot]
https://github.com/mozilla-mobile/firefox-android/commit/e0ee2aa8be972861a0f3cfb8c0ab8a99e0a52022
[releases_v117] Bug 1838389 - Catch NullPointerException while printStackTrace (#3187)

Comment 15

[Mira Lobontiu (Android QA)]

Verified on the latest Fenix Nightly 118.0a1 from 8/10 with the following devices:

• Google Pixel 6 (Android 14),
• Oppo Find X3 Lite (Android 11), and
• Sony Xperia Z5 Premium (Android 7.1.1).

I've typed about:crashparent into a tab, to trigger a crash, and to test if a crash happens during crash reporting.
A crash did happend during crash reporting, but with a different signature than from this ticket, therefor I've filed a new bug: 1848134.

Roger, it there a different scenario that I could test in order to verify this ticket?
Thank you!

Comment 16

[Roger Yang [:royang]]

:miralobontiu, Yes that looks like a different issue. Thanks for filing the new bug.

Comment 17

[Dianna Smith [:diannaS]]

Comment on attachment 9348226 [details] [review]
[mozilla-mobile/firefox-android] Bug 1838389 - Catch NullPointerException while printStackTrace (backport #3063) (#3188)

Approved for Mobile 116.3.0

Comment 18

[BMO Github Automation]

Authored by https://github.com/mergify[bot]
https://github.com/mozilla-mobile/firefox-android/commit/71291f8349d11278590c179cdbe18433e317a1c5
[releases_v116] Bug 1838389 - Catch NullPointerException while printStackTrace (#3188)

Comment 19

[Adina Petridean QA [:apetridean]]

Verified as fixed on Firefox RC 116.3.0
Devices used: Huawei Mate 20 Lite(Android 10), Google Pixel 6 (Android 14), Samsung Galaxy Tab S3 (Android 9), Lenovo Yoga Tab 11 (Android 12) .