1849015 - Crash on crash reporter

Status: RESOLVED DUPLICATE of bug 1838389

(Firefox for Android :: Crash Reporting, defect, P2)

Description

[fabianroeling]

User Agent: Mozilla/5.0 (Android 10; Mobile; rv:109.0) Gecko/116.0 Firefox/116.0

Steps to reproduce:

Opened a bunch of bookmarks, got crash, reported from notification.

Actual results:

1cb54f1f-11f5-4fa7-9d97-b4bf58d29ac2
java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.String java.lang.Object.toString()' on a null object reference

java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.String java.lang.Object.toString()' on a null object reference
at java.lang.String.valueOf(String.java:2924)
at java.lang.StringBuilder.append(StringBuilder.java:132)
at java.lang.Throwable.printEnclosedStackTrace(Throwable.java:709)
at java.lang.Throwable.printStackTrace(Throwable.java:674)
at java.lang.Throwable.printStackTrace(Throwable.java:735)
at mozilla.components.support.base.ext.ThrowableKt.getStacktraceAsString$default(Throwable.kt:19)
at mozilla.components.lib.crash.service.MozillaSocorroService.sendCrashData(MozillaSocorroService.kt:607)
at mozilla.components.lib.crash.service.MozillaSocorroService.sendReport$lib_crash_release(MozillaSocorroService.kt:285)
at mozilla.components.lib.crash.service.MozillaSocorroService.report(MozillaSocorroService.kt:5)
at mozilla.components.lib.crash.CrashReporter$submitReport$2.invokeSuspend(CrashReporter.kt:70)
at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:9)
at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:112)
at kotlinx.coroutines.internal.LimitedDispatcher$Worker.run(LimitedDispatcher.kt:4)
at kotlinx.coroutines.scheduling.TaskImpl.run(Tasks.kt:3)
at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:96)
Suppressed: kotlinx.coroutines.internal.DiagnosticCoroutineContextException: [StandaloneCoroutine{Cancelling}@6aec4f8, Dispatchers.IO]

Comment 1

[fabianroeling]

If someone's interested, here is the original bookmarks crash. But I can't reproduce it, so I'm not making another bug report.

300e77b6-00e5-458d-ae84-d1202c866a1b
java.lang.NullPointerException

• New Sentry Instance: https://sentry.io/organizations/mozilla/issues/?project=6375561&query=9fd75a9f565c460b91e4977064d87e83

---

java.lang.NullPointerException
at org.mozilla.fenix.library.bookmarks.BookmarkFragment.refreshBookmarks(BookmarkFragment.kt:103)
at org.mozilla.fenix.library.bookmarks.BookmarkFragment$refreshBookmarks$1.invokeSuspend(BookmarkFragment.kt:14)
at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:9)
at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:112)
at android.os.Handler.handleCallback(Handler.java:883)
at android.os.Handler.dispatchMessage(Handler.java:100)
at android.os.Looper.loop(Looper.java:214)
at android.app.ActivityThread.main(ActivityThread.java:7400)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:491)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:935)
Suppressed: kotlinx.coroutines.internal.DiagnosticCoroutineContextException: [StandaloneCoroutine{Cancelling}@26f4bf6, Dispatchers.Main]

Comment 2

[[:owlish] 🦉 PST]

Hey Roger could you take a look please?

Comment 3

[Roger Yang [:roger]]

Sure, looks like there are two issues here. I'll take a look at the crash reporter crash first.

Comment 4

[fabianroeling]

That's definitely the more important one, it seems to break all crash reporting and therefore blocks knowing about many other crashes. The other one I couldn't even reproduce with the exact same actions.

Comment 5

[Roger Yang [:roger]]

Looks like this issue is due to getStacktraceAsJsonString throwing NullPointerException even though throwable is not null. Very similar to the issue we ahve with printStackTrace. The only solution here is to catch it and continue with the crash submission.

Comment 6

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1849015 - Catch NullPointerException while getStacktraceAsJsonString (#3457)

Comment 7

[Roger Yang [:roger]]

A second look I noticed that this is the crash that we fixed already recently. It's not from the getStacktraceAsJsonString but from the getStacktraceAsString. Closing this as dup.

Comment 9

[Roger Yang [:roger]]

:fabianroeling, do we want to create another bug for the bookmark crash? Thanks

Comment 10

[fabianroeling]

Not really useful without reproduction steps IMO. It happened exactly once. Could be a cosmic ray from all I know.