1838627 - Expose desugaredSelector property on StyleRuleActor form for nested rule

Status: RESOLVED FIXED

(DevTools :: Inspector: Rules, task, P1)

Description

[Nicolas Chevobbe [:nchevobbe]]

We need the full desugared selector in the inspector for a few different things (matching style for a rule, selector highlighter, …), so let's expose it from the server.

We might also put it for each ancestor so we could also display it for parent rules if need be

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Emilio, is this something platform keeps around for a given rule? If so, can you point me to it so I can try to expose it for chome access?
Not the end of the world if this is not the case, it shouldn't be too hard to do in JS

Comment 2

[Emilio Cobos Álvarez [:emilio]]

We don't, we generate those dynamically later, but it shouldn't be too hard to do... Curious, do you always want the desugared selector for a given rule? Or do you need something like CSSStyleRule.desugarSelectorWith(UTF8String parentSelector)? Either way is probably fine.

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Oh, also, do you want the whole selector text? Or the selector at one position? We have a bunch of APIs for DevTools that do the later, so just wondering.

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #2)

We don't, we generate those dynamically later, but it shouldn't be too hard to do... Curious, do you always want the desugared selector for a given rule? Or do you need something like CSSStyleRule.desugarSelectorWith(UTF8String parentSelector)? Either way is probably fine.

Yeah we'll probably always want the desugared selector for a rule, since we'll need it for our highlighter selector (Bug 1838163), and I also think it will be useful to display it for the user (Bug 1838626)(In reply to Emilio Cobos Álvarez (:emilio) from comment #3)

Oh, also, do you want the whole selector text? Or the selector at one position? We have a bunch of APIs for DevTools that do the later, so just wondering.

Yeah the whole selector text is what we want for this case

Comment 5

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1838627 - Refactor InspectorUtils APIs that just forward to CSSStyleRule, and expose desugared selectors on them. r=nchevobbe

Comment 7

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1838627 - [devtools] Expose desugared selectors on style rule actor. r=#devtools-reviewers.

Depends on D181109

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/782b982f3a81
Refactor InspectorUtils APIs that just forward to CSSStyleRule, and expose desugared selectors on them. r=nchevobbe,webidl,firefox-style-system-reviewers,smaug,devtools-reviewers,boris

Comment 9

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/782b982f3a81

Comment 10

[Phabricator Automation]

Comment on attachment 9340225 [details]
Bug 1838627 - [devtools] Expose desugared selectors on style rule actor. r=#devtools-reviewers.

Revision D181606 was moved to bug 1838163. Setting attachment 9340225 [details] to obsolete.