1884969 - Remove Gecko preference "mirroring" to the Windows registry

Status: NEW

(Toolkit :: Default Browser Agent, task, P3)

Description

[Nick Alexander :nalexander [he/him] (PTO Feb 24-March 3)]

Almost all of https://searchfox.org/mozilla-central/source/toolkit/xre/nsAppRunner.cpp#2345-2493 can be removed. I think that SetDefaultAgentLastRunTime is still used at https://searchfox.org/mozilla-central/rev/f9157a03835653cd3ece8d2dc713a782b7e4374e/toolkit/mozapps/defaultagent/DefaultAgent.cpp#221, but I believe the following are no longer used:

• OnDefaultAgentTelemetryPrefChanged: the telemetry is now Glean, and I think opt-out is via a policy;
• OnSetDefaultBrowserUserChoicePrefChanged: this pref is no longer relevant
• OnDefaultAgentRemoteSettingsPrefChanged: the consuming code was removed in Bug 1838754

Comment 1

[Nick Alexander :nalexander [he/him] (PTO Feb 24-March 3)]

nrishel: am I wrong about any of these?

Comment 2

[Nick Rishel [:nrishel]]

• OnDefaultAgentTelemetryPrefChanged: Keep it - Glean policy is profile specific and we don't mirror the main profile to background tasks. We also still have PingSender telemetry. Thinking longer term (post PingSender removal) we could switch the registry key to a background tasks call (e.g. firefox --backgroundtask defaultagent telemetry-opt-out, but I'm not in love with this solution until we come to a conclusion on how we want to handle the "profile launched with a newer version" issue, we wouldn't want implement this if we decide to delete the profile as it would lose the telemetry opt-out.
• OnSetDefaultBrowserUserChoicePrefChanged: Remove.
• OnDefaultAgentRemoteSettingsPrefChanged: Remove.

Comment 3

[Nick Rishel [:nrishel]]

:nalexander, did you mean you believe Glean telemetry opt-out is handled via a Windows policy?