1838758 - fully manually configured account is silently deleted on Finish if no password as provided

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, defect)

Description

[Sean Burke [:leftmostcat]]

I can reproduce this consistently with the following steps:

1. Open account creation screen (either in new profile or from Account Settings page)
2. Manually configure an IMAP+SMTP account and select Done

At this point, it's possible to open the Account Settings page and see that the account is present and to open the message list and see the account, with emails being downloaded.

3. Select Finish on the account setup page

The account will still be present in Account Settings, but its name will have changed, all server settings will have been wiped, and it is no longer visible in the message list.

Comment 1

[Magnus Melin [:mkmelin]]

Oh I see, it doesn't happen if you first find something and then manually change. Only if you go directly to manual.

Comment 2

[Magnus Melin [:mkmelin]]

For the bug to reproduce you must leave the password field blank.

Comment 3

[Magnus Melin [:mkmelin]]

Attachment: Bug 1838758 - Use centralized cleanup() in config verifier. r=leftmostcat

There were cases where the temporary server was removed but not nulled out. Since it was not nulled out in those cases,
"onunload" handling removed a matching server which we did want to keep.

This occurred since no verification of password will take place if none was provided (and not OAuth2).
Normally after verification a proper cleanup step would take place, but since there was not verification,
this.server was left non-null.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/37c3a52795c5
Use centralized cleanup() in config verifier. r=leftmostcat

Comment 5

[Magnus Melin [:mkmelin]]

Comment on attachment 9339452 [details]
Bug 1838758 - Use centralized cleanup() in config verifier. r=leftmostcat

[Approval Request Comment]
Regression caused by (bug #): bug 1788086
User impact if declined: in the given case, the just set up account would instantly be removed
Testing completed (on c-c, etc.): c-c
Risk to taking this patch (and alternatives if risky): it's well understood and should be safe

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9339452 [details]
Bug 1838758 - Use centralized cleanup() in config verifier. r=leftmostcat

[Triage Comment]
Approved for beta

Comment 7

[Daniel Darnell [:dandarnell]]

Thunderbird 115.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/6e3cd3349198