1840092 - Windows notification action switches to Thunderbird with Message Pane View, but pane was disabled

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect, P2)

Description

[Mark Cathcart]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/114.0.0.0 Safari/537.36 Edg/114.0.1823.43

Steps to reproduce:

When a new mail arrives a Windows notification is triggered on the lower right of my screen. Ignoring the notification and switching to TB115.0b3 displays the main window view as configured with the message pane switched off.

Actual results:

If I click on the email notification, TB115.0b3 is bought to the front but the message pane is in view irrespective of the user setting to off. F8 is now living in my head rent free.

Expected results:

However the switch is made on clicing a notification, the users view of the main TB window should be respected. A better alternative would be to actually open the message per the user view options.

Comment 1

[Buddy J.]

Can confirm for Thunderbird 115.0.1 on macOS 13.4.1. Clicking the notification opens the message in the message pane even though I explicitly disabled the pane.

Comment 3

[Wayne Mery (:wsmwk)]

We now have multiple reports of this.

However the switch is made on clicing a notification, the users view of the main TB window should be respected. A better alternative would be to actually open the message per the user view options.

Reporters, in Settings, what you have set for "Open messages in:" ?

Comment 4

[Buddy J.]

I have "Open messages in" set to "A new tab".

Comment 5

[[:nickname]JN]

@wsmwk: I have the problem and my 'Open messages in' setting (within Settings -> 'Reading and Display') is 'A new message window'.

Comment 6

[Alessandro Castellani [:aleca]]

Geoff, could you tackle this?

Comment 7

[Geoff Lankow (:darktrojan)]

Yeah, I'll fix this. It should just be a case of not opening the message pane. However, I think it would make more sense (if the pane is not open) to open the message in a tab or window depending on the preference. Otherwise clicking on the notification does nothing except select the message in a list, which is a bit useless.

Comment 8

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1840092 - Fix and test what happens when the new mail notification is clicked. r=#thunderbird-front-end-reviewers

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/19e3fa1112b5
Fix and test what happens when the new mail notification is clicked. r=aleca

Comment 10

[Geoff Lankow (:darktrojan)]

Comment on attachment 9348120 [details]
Bug 1840092 - Fix and test what happens when the new mail notification is clicked. r=#thunderbird-front-end-reviewers

[Approval Request Comment]
Regression caused by (bug #): bug 1832383
User impact if declined: message pane opens unexpectedly
Testing completed (on c-c, etc.): landed 4 days ago with a test (not a great one but better than nothing)
Risk to taking this patch (and alternatives if risky): low

Comment 11

[Wayne Mery (:wsmwk)]

Comment on attachment 9348120 [details]
Bug 1840092 - Fix and test what happens when the new mail notification is clicked. r=#thunderbird-front-end-reviewers

[Triage Comment]
Approved for beta

Comment 12

[Daniel Darnell [:dandarnell]]

Thunderbird 117.0b5:
https://hg.mozilla.org/releases/comm-beta/rev/ba67b0c91731

Comment 13

[Geoff Lankow (:darktrojan)]

Comment on attachment 9348120 [details]
Bug 1840092 - Fix and test what happens when the new mail notification is clicked. r=#thunderbird-front-end-reviewers

[Approval Request Comment]
Regression caused by (bug #): bug 1832383
User impact if declined: message pane opens unexpectedly
Testing completed (on c-c, etc.): in 117 beta 5
Risk to taking this patch (and alternatives if risky): low

Comment 14

[Mark Cathcart]

Will the fix for this be rolled back to 115?
The problem exists on 115.2.0 (64-bit).

Thank you.

Comment 15

[Wayne Mery (:wsmwk)]

Comment on attachment 9348120 [details]
Bug 1840092 - Fix and test what happens when the new mail notification is clicked. r=#thunderbird-front-end-reviewers

[Triage Comment]
Approved for esr115

Comment 16

[Daniel Darnell [:dandarnell]]

Thunderbird 115.2.1:
https://hg.mozilla.org/releases/comm-esr115/rev/74f8a44d0d5f