1841442 - Finish integrating Pocket suggestions with rich suggestions

Status: VERIFIED FIXED

(Firefox :: Address Bar, task, P1)

Description

[Drew Willcoxon :adw]

The patch in bug 1841408 does a lot of the work but I didn't want to make it bigger than necessary so there's still some work left to do.

Comment 1

[Drew Willcoxon :adw]

Attachment: Bug 1841442 - Finish integrating Pocket suggestions with rich suggestions.

• Add the "Pocket - Related to {keyword}" bottom text
• Don't show the description for non-top-picks
• Make sure the URL is always shown

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d5d7d96fbe33
Finish integrating Pocket suggestions with rich suggestions. r=daisuke,fluent-reviewers,flod

Comment 3

[Drew Willcoxon :adw]

STR for QA:

This bug implements the final Pocket UI as shown in the Figma (see "CD Work area" in the left sidebar, then the "V4 - Final" group in the main pane). Both "low confidence" (non-top-pick) and "high confidence" (top pick) Pocket suggestions should appear more or less like they do in the Figma. Expected differences:

• This bug does not implement the "Recommended reads" label above the suggestion, so it will still say "Top pick"
• The Feedback menu is expected to appear in both high and low confidence. The Figma is incorrect on this. However there's a bug where the button may sometimes not appear in the low confidence suggestion, so if it doesn't appear, don't worry about it. It's fixed in bug 1841409 and we can verify the behavior there.
• This bug does not implement all the behavior and menu items of the Feedback menu
• The separator between the suggestion title and URL is expected to be an em dash ("—") as usual, not a dot like it is in the Figma

STR:

1. Set browser.urlbar.pocket.featureGate = true to enable Pocket suggestions and browser.urlbar.bestMatch.enabled to enable best match
2. Type "breakfas" (no "t" at the end) and verify a Pocket suggestion does not appear
3. Finish typing "breakfast" (with a "t" at the end) and verify a "Cat Cora" Pocket suggestion appears at the bottom of the urlbar panel. It should have: a Pocket icon, title, URL, some text at the bottom that says "Pocket" and the full keyword that matches what you typed, Feedback button
4. Continue typing "breakfast casserole" and verify the suggestion remains in the panel. In the text at the bottom of the suggestion, the part of the full keyword that you typed should be bold, and the rest of the keyword should not be bold.
5. Clear the input and type "breakfast paninis". The "Cat Cora" suggestion should appear after you finish typing "breakfast" and "breakfast ", as before. After that, no suggestion should appear until you fully type "breakfast paninis". A top pick suggestion should appear called "Your New Favorite Breakfast Sandwich is Anything but Basic". It should have the same appearance as the "low" confidence suggestion except it should also have a long description under the title.

If you'd like, you can test other keywords and suggestions by looking at the spreadsheet. See the low and high confidence keyword columns. The keywords in each column are separated by commas, and note that each keyword string can contain more than one word.

• Low confidence keywords can be triggered by typing the first word in the keyword, followed by one or more characters after that
• High confidence keywords must be typed in full

Comment 4

[Drew Willcoxon :adw]

Comment on attachment 9342052 [details]
Bug 1841442 - Finish integrating Pocket suggestions with rich suggestions.

Beta/Release Uplift Approval Request

• User impact if declined: This bug is necessary for the Pocket suggestions feature we intend to ship as an experiment in 116.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Please see STR in previous comment
• List of other uplifts needed: The following bugs must be uplifted first: 1841354, Bug 1841295, Bug 1841553, Bug 1841408
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Only affects Pocket suggestions, which are disabled by default. Has tests.
• String changes made/needed: None: This patch modifies the Firefox Suggest FTL file, but the file is not localized. It is en-US only.
• Is Android affected?: No

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/d5d7d96fbe33

Comment 6

[Dianna Smith [:diannaS]]

Comment on attachment 9342052 [details]
Bug 1841442 - Finish integrating Pocket suggestions with rich suggestions.

Approved for 116.0b2

Comment 7

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/3935d29947b8

Comment 8

[Carmen Fat [:cfat] - Ecosystem QA]

I have verified this issue on the latest Firefox Nightly 117.0a1 (Build ID: 20230706092222), on Windows 10 x64, macOS 13.4.1, and Ubuntu 20.04 x64.

• I can confirm that there is no Pocket suggestion displayed when the typed string is not complete (“breakfas”);
• The "Cat Cora" Pocket suggestion appears at the bottom of the Urlbar panel (Firefox Suggest section) after typing the complete string (“breakfast”);
• The Pocket suggestion displays: the Pocket icon, the title, the URL, some text at the bottom that says "Pocket" and the full keyword that matches what you typed, and the Feedback button.
• The "Cat Cora" Pocket suggestion remains displayed when continuing typing another string (“breakfast casserole”);
• In the text at the bottom of the suggestion, the part of the full keyword that was typed is bold, and the rest of the keyword is not bold.
• The "Cat Cora" Pocket suggestion remains displayed when the prefix string is completely typed and a space is added after it (“breakfast “);
• There is no Pocket suggestions displayed when "breakfast panini" is typed in the Address Bar;
• The "Your New Favorite Breakfast Sandwich is Anything but Basic" Pocket suggestion is displayed in the Top Pick section when all the strings are completely typed (“breakfast paninis”).
• The top Pick Pocket suggestion displays: the Pocket icon, the title, the URL, some text at the bottom that says "Pocket" and the full keyword that matches what you typed, the long description, and the Feedback button.

Comment 9

[Carmen Fat [:cfat] - Ecosystem QA]

I have verified this issue on the latest Firefox Beta 116.0b2 (Build ID: 20230706193912), on Windows 10 x64, macOS 13.4.1, and Ubuntu 20.04 x64.

• I can confirm that there is no Pocket suggestion displayed when the typed string is not complete (“breakfas”);
• The "Cat Cora" Pocket suggestion appears at the bottom of the Urlbar panel (Firefox Suggest section) after typing the complete string (“breakfast”);
• The Pocket suggestion displays: the Pocket icon, the title, the URL, some text at the bottom that says "Pocket" and the full keyword that matches what you typed, and the Feedback button.
• The "Cat Cora" Pocket suggestion remains displayed when continuing typing another string (“breakfast casserole”);
• In the text at the bottom of the suggestion, the part of the full keyword that was typed is bold, and the rest of the keyword is not bold.
• The "Cat Cora" Pocket suggestion remains displayed when the prefix string is completely typed and a space is added after it (“breakfast “);
• There is no Pocket suggestions displayed when "breakfast panini" is typed in the Address Bar;
• The "Your New Favorite Breakfast Sandwich is Anything but Basic" Pocket suggestion is displayed in the Top Pick section when all the strings are completely typed (“breakfast paninis”).
• The Pocket suggestion displays: the Pocket icon, the title, the URL, some text at the bottom that says "Pocket" and the full keyword that matches what you typed, the long description, and the Feedback button.