1842490 - Missing text / strings for permissions in addons manager

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: General, defect)

Description

[Alex Ihrig [:Thunderbird_Mail_DE]]

Attachment: Screenshot

In Thunderbird 115 RC build 1 the strings for permissions in addons manager are missing and you can only read "null" for these WebExtensions permissions. This is for different locales like Dutch and German - maybe all locales?

Comment 1

[John Bieling]

This is partially being taken care of in https://bugzilla.mozilla.org/show_bug.cgi?id=1852249. Once that landed, we can fix Thunderbird.

Comment 2

[John Bieling]

Attachment: Bug 1842490 - Fix missing descriptions for permissions in addons manager. r=#thunderbird-reviewers

Comment 3

[Magnus Melin [:mkmelin]]

Sorry this has some (non-trivial) linting issues.

Comment 4

[John Bieling]

I think Martin actually pointed that out to me earlier and I forgot about it. You will get a review shortly.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0d6b81acbc27
Fix missing descriptions for permissions in addons manager. r=mkmelin

Comment 6

[John Bieling]

Comment on attachment 9354056 [details]
Bug 1842490 - Fix missing descriptions for permissions in addons manager. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): 1793557
User impact if declined: Missing permission descriptions in the permission tab of AOM
Testing completed (on c-c, etc.): 2 days
Risk to taking this patch (and alternatives if risky): low (tested locally, covered by m-c tests)

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9354056 [details]
Bug 1842490 - Fix missing descriptions for permissions in addons manager. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 8

[Daniel Darnell [:dandarnell]]

Thunderbird 119.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/a2714d296930

Comment 9

[John Bieling]

I manually tested https://treeherder.mozilla.org/jobs?repo=comm-beta&revision=de771cb0153e527e1251d902d644ee79c3596576&selectedTaskRun=ZxXTH71lTkGb_lgnx3bhPQ.0 and it is fixed.

The corresponding m-c patch has been uplifted to m-c ESR115, so we can uplift this to c-c ESR115 now as well.

Comment 10

[John Bieling]

Comment on attachment 9354056 [details]
Bug 1842490 - Fix missing descriptions for permissions in addons manager. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): 1793557
User impact if declined: Missing permission descriptions in the permission tab of AOM
Testing completed (on c-c, etc.): successfully tested on beta (https://treeherder.mozilla.org/jobs?repo=comm-beta&revision=de771cb0153e527e1251d902d644ee79c3596576&selectedTaskRun=ZxXTH71lTkGb_lgnx3bhPQ.0)
Risk to taking this patch (and alternatives if risky): low (tested locally, covered by m-c tests)

Comment 11

[Wayne Mery (:wsmwk)]

Comment on attachment 9354056 [details]
Bug 1842490 - Fix missing descriptions for permissions in addons manager. r=#thunderbird-reviewers

[Triage Comment]
Approved for esr115

Comment 12

[Rob Lemley [:rjl]]

Thunderbird 115.3.2:
https://hg.mozilla.org/releases/comm-esr115/rev/380a749c9f20

Comment 13

[Rob Lemley [:rjl]]

Backout comm-esr115:
https://hg.mozilla.org/releases/comm-esr115/rev/d78c0c2372da

The GRE bug is not in 115.3.x, it won't be until 115.4.0.
All tests are failing miserably because of this.

Comment 14

[Daniel Darnell [:dandarnell]]

Thunderbird 115.4.0:
https://hg.mozilla.org/releases/comm-esr115/rev/a10e67eacc8e