Tabs reordering and animation issues
Categories
(Fenix :: Tabs, defect, P2)
Tracking
(firefox115 unaffected, firefox116 unaffected, firefox117 disabled, firefox118 disabled, firefox119 verified)
| Tracking | Status | |
|---|---|---|
| firefox115 | --- | unaffected |
| firefox116 | --- | unaffected |
| firefox117 | --- | disabled |
| firefox118 | --- | disabled |
| firefox119 | --- | verified |
People
(Reporter: tyotomy, Assigned: aputanu)
References
(Regression)
Details
(Keywords: regression)
Attachments
(3 files)
Actual results:
In the latest Nightly version, the behavior of tabs has become strange, and tabs can no longer be moved by long-pressing them.
Also, the animation for clearing tabs with a swipe has been removed, and tabs disappear instantly when swiped, so the animation remains strange.
It seems that deleting tabs by swiping is becoming easier, and tabs are often accidentally deleted when trying to scroll through the tab list.
Firefox version is 117.0a1 (Build #2015962147).
|
||
Comment 2•2 years ago
|
||
Probably a regression from the recent Compose work which was enabled a couple days ago.
|
||
Updated•2 years ago
|
|
|
||
Comment 3•2 years ago
|
||
hey, :tesmite, thanks for filing this ticket! For context, we just enabled a big UI rewrite in the Tabs Tray this week, and the updated tab reordering is slated to land within the next two weeks as part of Bug 1810780. That particular feature has proven to be complicated to convert without compromising the code, so I appreciate you bearing with us while the Tabs Tray undergoes some reconstruction.
Regarding the swipe to delete, this is a known issue but a ticket has yet to be filed, so let's use this ticket to track that specific regression.
If at any point you would like to opt-out of the rewrite, you can turn off the changes by enabling Secret settings and disabling the setting called "Enable Tabs Tray to Compose". You can unlock the Secret Settings page by going to Settings -> About Firefox Fenix -> tap on the logo at the top 5 times.
Thanks for your patience.
|
|
||
Updated•2 years ago
|
|
|
||
Updated•2 years ago
|
|
||
Comment 4•2 years ago
|
||
Set release status flags based on info from the regressing bug 1815001
|
|
||
Updated•2 years ago
|
|
||
Updated•1 years ago
|
|
|
||
Comment 8•1 years ago
|
||
Hey :tesmite, thanks for your patience with this. Both swipe to delete and tab reordering are live in Nightly with the rewrite.
Let me know if the bugs you originally reported are resolved, and I can close this ticket as resolved.
The previous issues appear to be resolved, however reordering tabs has a flicker when the animation starts. The tab being dragged briefly appears adjacent to the finger in the direction of travel.
|
|
||
Comment 10•1 years ago
|
||
The previous issues appear to be resolved, however reordering tabs has a flicker when the animation starts. The tab being dragged briefly appears adjacent to the finger in the direction of travel.
cc: aputanu
|
Assignee | |
Comment 11•1 years ago
|
||
The issue seems to be caused by the list being updated later than us updating the tab's position, so when a tab moves to a new index, it picks up the offset from the previous position. I'll create a patch to fix this.
|
||
Comment 12•1 years ago
|
||
|
|
||
Comment 13•1 years ago
|
||
Authored by https://github.com/Alexandru2909
https://github.com/mozilla-mobile/firefox-android/commit/a12d1af19a8cb7c427d02ec548055a4fdf635876
[main] Bug 1843536 - Fix tab reordering animation issues
|
||
Comment 14•1 years ago
•
|
||
Managed to reproduce on yesterday's Nightly build (119.0a1 from 2023-09-12).
Verified as fixed on today's Nightly build (119.0a1 from 2023-09-13).
The issue presented in the video cannot be reproduced anymore, though there are moments when all the tabs "blink" slightly simultaneously, as can be seen in the attached video. Deleting a tab is as expected.
Device used: Google Pixel 7 (Android 14).
Marking the ticket as verified for 119.
|
|
||
Comment 15•1 years ago
|
||
|
|
||
Updated•1 years ago
|
|
Reporter | |
Comment 16•1 year ago
|
||
(In reply to Noah Bond [:007] from comment #8)
Hey :tesmite, thanks for your patience with this. Both swipe to delete and tab reordering are live in Nightly with the rewrite.
Let me know if the bugs you originally reported are resolved, and I can close this ticket as resolved.
Yes, I think the issue I raised has been resolved.
I have not confirmed any other issues.
Description
•