1844341 - Tools>Filters does not open if I am in a unified folder eg Unified Inbox.

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Carl Hansen]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/114.0.0.0 Safari/537.36 OPR/100.0.0.0

Steps to reproduce:

Tried to open Tools>filters while in unfied inbox

Opera One(version: 100.0.4815.76)

Actual results:

Filters did not open

Expected results:

Filters page open

Comment 1

[Wayne Mery (:wsmwk)]

Uncaught : Component returned failure code: 0x80550018 [nsIMsgDBView.hdrForFirstSelectedMessage]
MsgFilters chrome://messenger/content/mailWindowOverlay.js:1311
oncommand chrome://messenger/content/messenger.xhtml:1

Comment 2

[Alessandro Castellani [:aleca]]

I can't reproduce this, the filters dialog opens for me in unified folder mode

Comment 3

[Wayne Mery (:wsmwk)]

Carl, does this still reproduce for you? WIth which version?

I retested every unified folder type with beta on Mac and all fail - not all with something in error console. I'll test Windows tomorrow.

Eventually I crashed bp-aae6c0ea-2620-4daa-854f-5c1a50230912 EMPTY: no frame data available; MissingThreadList

Comment 4

[Magnus Melin [:mkmelin]]

I see this. Maybe the missing step is no message should be selected.

Comment 5

[Magnus Melin [:mkmelin]]

Attachment: Bug 1844341 - Don't throw when getting nsIMsgDBView.hdrForFirstSelectedMessage for nsMsgViewIndex_None. r=darktrojan

Comment 6

[Carl Hansen]

Actually if I select a message in a unified folder then I can open the filters for the account receiving that message. It is when I am in a unified folder with no message selected that Tools>filters opens nothing. Maybe that is how it is meant to work.

Comment 7

[Magnus Melin [:mkmelin]]

Attachment: Bug 1844341 - Fix Tools>Filters for unfied folder and no message selected. r=darktrojan

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f901613c1754
Fix Tools>Filters for unfied folder and no message selected. r=darktrojan

Comment 9

[Magnus Melin [:mkmelin]]

Comment on attachment 9357549 [details]
Bug 1844341 - Fix Tools>Filters for unfied folder and no message selected. r=darktrojan

[Approval Request Comment]
Regression caused by (bug #): supernova
User impact if declined: Tools | Filters don't work if in Unified folder
Testing completed (on c-c, etc.): c-c
Risk to taking this patch (and alternatives if risky): safe

Comment 10

[Wayne Mery (:wsmwk)]

Comment on attachment 9357549 [details]
Bug 1844341 - Fix Tools>Filters for unfied folder and no message selected. r=darktrojan

[Triage Comment]
Approved for beta

Comment 11

[Daniel Darnell [:dandarnell]]

Thunderbird 119.0b5:
https://hg.mozilla.org/releases/comm-beta/rev/af4d249b4983

Comment 12

[Wayne Mery (:wsmwk)]

Comment on attachment 9357549 [details]
Bug 1844341 - Fix Tools>Filters for unfied folder and no message selected. r=darktrojan

[Triage Comment]
Approved for esr115

Comment 13

[Daniel Darnell [:dandarnell]]

Thunderbird 115.4.0:
https://hg.mozilla.org/releases/comm-esr115/rev/5ddbf79031b8