1845345 - Remove the experimental flag for network intercept features

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, task, P2)

Description

[Julian Descottes [:jdescottes]]

We have several bugs to implement the individual pieces of network interception (add intercept, remove intercept etc...).

However we should not expose those commands to end users until we have at least one meaningful user story implemented, which will most likely be after Bug 1826196.

At this point we can consider removing the experimental flag for those features.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

We will not get to remove the flag in milestone 9. As such lets target it for M10.

Comment 2

[Julian Descottes [:jdescottes]]

Now that continueWithAuth landed, we could actually remove the experimental flag for network interception requests, because you can intercept and resume an authentication request.

The downside is that intercepts for any other phase cannot be resumed. We could still keep the experimental flag when people try to use addIntercept with other phases. The other option is to block this on the other continue commands (failRequest, continueRequest, continueResponse, provideResponse).

Comment 3

[Julian Descottes [:jdescottes]]

Let's check with puppeteer team if they need the continueWithAuth feature, otherwise we can keep it behind the flag until we have more APIs.

Comment 4

[alexrudenko]

We are currently blocked by our work on implementing request interception in general so we won't be able to make use continueWithAuth. I think it makes sense to turn it on once more interception APIs are ready. We could experiment with it being behind the flag in the meantime.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Thanks Alex. So lets leave it as experimental for now and we will remove it when required by Puppeteer or when we got the remaining APIs added. Lets block on those related bugs.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Given the wpt.fyi results I wonder why those are failing given that for Nightly the experimental APIs should be enabled. Maybe we should remove the flag for the network request interception methods now even with optional arguments not being supported yet?

Comment 7

[Julian Descottes [:jdescottes]]

This link is an old run using a Nightly from Feb 5 which didn't have my patch.

Tests are now passing:

• https://wpt.fyi/results/webdriver/tests/bidi/network/continue_request/invalid.py?label=experimental&label=master&aligned
• https://wpt.fyi/results/webdriver/tests/bidi/network/continue_response/invalid.py?label=experimental&label=master&aligned

Regarding the flag, I agree we can remove it, but this should not impact puppeteer tests or wpt.fyi.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Oh including the Android results in the list, which didn't seem to have newer results, caused the results to be outdated. Thanks for pointing that out.

Nevertheless once Nightly rides the trains to beta it would be broken. So yes, lets remove the flag and not wait for bug 1850680, bug 1853882, and bug 1853887.

Comment 9

[Julian Descottes [:jdescottes]]

Attachment: Bug 1845345 - [bidi] Remove the experimental flag for network intercept features

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b69847c15584
[bidi] Remove the experimental flag for network intercept features r=webdriver-reviewers,whimboo

Comment 11

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/b69847c15584

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+1]]

With enabling network interception we should announce all the available APIs in the MDN release notes of the next Firefox release.