Closed Bug 1853887 Opened 1 year ago Closed 1 month ago

Add support for cookies and headers arguments for "network.continueResponse" command

Categories

(Remote Protocol :: WebDriver BiDi, task, P2)

task
Points:
5

Tracking

(firefox131 fixed)

RESOLVED FIXED
131 Branch
Tracking Status
firefox131 --- fixed

People

(Reporter: whimboo, Assigned: jdescottes)

References

(Blocks 2 open bugs, )

Details

(Whiteboard: [webdriver:m12][wptsync upstream][webdriver:relnote])

Attachments

(3 files)

No description provided.
Points: --- → 5
Priority: -- → P2
Whiteboard: [webdriver:m9]
Whiteboard: [webdriver:m9] → [webdriver:m10]
Depends on: 1874206

With bug 1874206 the plan is to cover the required arguments only for now.

Summary: Implement "network.continueResponse" command → Add support for optional arguments for "network.continueResponse" command
Whiteboard: [webdriver:m10] → [webdriver:m11]
Whiteboard: [webdriver:m11] → [webdriver:m12]
Blocks: 1913737
Summary: Add support for optional arguments for "network.continueResponse" command → Add support for cookies and headers arguments for "network.continueResponse" command
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Blocks: 1914351
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0369bdef1027 [bidi] Add support for cookies and headers arguments for network.continueResponse r=webdriver-reviewers,Sasha https://hg.mozilla.org/integration/autoland/rev/9ade690726e2 [wdspec] Add wdspec tests for cookies and headers parameters for network.continueResponse r=webdriver-reviewers,Sasha https://hg.mozilla.org/integration/autoland/rev/1da1c517324f [wdspec] Add mozilla specific test for immutable header names for network.continueResponse r=webdriver-reviewers,Sasha
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/47765 for changes under testing/web-platform/tests
Whiteboard: [webdriver:m12] → [webdriver:m12], [wptsync upstream]

Backed out for causing wd failures in headers.py

  • Backout link
  • Push with failures
  • Failure Log
  • Failure line: TEST-UNEXPECTED-FAIL | /webdriver/tests/bidi/network/provide_response/headers.py | test_set_cookie_header_and_cookies_before_request_sent - AssertionError: assert 1 == 2
Flags: needinfo?(jdescottes)
Upstream PR was closed without merging

A last minute test update highlighted an existing implementation issue. Patches updated, waiting for try results before attempting to re-land

https://treeherder.mozilla.org/jobs?repo=try&revision=ae7ffa4cd721aa61f98e9dc198c17cf727d87ba7

Flags: needinfo?(jdescottes)
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9b215ea63458 [bidi] Add support for cookies and headers arguments for network.continueResponse r=webdriver-reviewers,Sasha https://hg.mozilla.org/integration/autoland/rev/24b0d595e9b9 [wdspec] Add wdspec tests for cookies and headers parameters for network.continueResponse r=webdriver-reviewers,Sasha https://hg.mozilla.org/integration/autoland/rev/72645ecbb9f6 [wdspec] Add mozilla specific test for immutable header names for network.continueResponse r=webdriver-reviewers,Sasha
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 131 Branch
Upstream PR merged by moz-wptsync-bot
Whiteboard: [webdriver:m12], [wptsync upstream] → [webdriver:m12][wptsync upstream][webdriver:relnote]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: