1846482 - Reorganize and tweak mathvariant tests

Status: RESOLVED FIXED

(Core :: MathML, task)

Description

[Frédéric Wang (:fredw)]

This is a follow-up of bug 1821980 regarding existing tests relying on mathvariant.

Comment 1

[Frédéric Wang (:fredw)]

Attachment: Bug 1846482 - Reorganize and tweak mathvariant tests. r=emilio

414123.xhtml: The original test was checking that for dynamically
constructed MathML expressions, single-char '<mi>'s have italic style
applied. This used to be done via CSS but the test was later changed to
use <mi mathvariant="italic">. mathvariant="italic" is not longer
valid in MathML Core, so remove this explicit attribute and only verify
that dynamically constructed expression matches the static version of
the MathML tree. Also rename the test and move it to MathML WPT tests.

mi-mathvariant-1: The first test is verifying that multi-char mi is
rendered the same as mathvariant="normal". The second test is to verify
that single-char mi is rendered the same as mathvariant="italic"
(not in MathML Core) but there are better existing tests for that so
just tweak the reference to ignore it (using U+0078 in the reference
won't work on Android devices without proper math fonts).

mi-mathvariant-2: The two first tests verify that automatic italic is
not applied on U+221E and U+210E. The third test verifies fraktur B via
mathvariant="fraktur" (not in MathML Core) and is already covered by
mozilla/tests/mathml/mathvariant/mathvariant-fraktur.html

mi-mathvariant-3.html: This one is testing that single-char mi
(automatic italic) are not rendered with Tofu characters. This is very
similar to basic-mathematical-alphanumeric-symbols-with-default-font so
put it in the same directory and use similar name. It's still worth to
keep the test as it allows to exercise the preference
mathml.mathvariant_styling_fallback.disabled=false on Android.

mpadded-7,8,9: These tests are for mpadded, the use of the legacy
mathvariant="monospace" can be replaced with the equivalent use of the
corresponding Unicoded code points.

mathvariant-1a,1b,1c,1d,2,3,4,5: These are testing support for the
mathvariant attribute values that are not in MathML Core so move them
to testing/web-platform/mozilla/tests/mathml/mathvariant/. Keep the
failure expectation for Android (bug 1010679). The one for windows
(bug 1392106) seems to have been removed already.

table-width-4.html: Some tests are using legacy mathvariant values but
running with support disabled. Equivalent tests using corresponding
Unicode code points are provided in the same file.

whitespace-trim-3.html: This is using legacy mathvariant="italic" but
running with support disabled. It's done on single-char mi so the
attribute is useless anyway.

font-inflation-1.html: This is using legacy mathvariant="fraktur" but
should be equivalent to using the corresponding Unicode character.

dtls-3.html: This is similar to the other dtls tests, but using the
fraktur a instead of normal a. However, it's also specifically
checking update when mathvariant attribute is attached/removed so keep
it without change for now.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6eeabdff7159
Reorganize and tweak mathvariant tests. r=emilio

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/41275 for changes under testing/web-platform/tests

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/6eeabdff7159

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot