1856524 - [css-properties-values-api] Use canonical units for custom properties with font-relative values

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Tess Hoffman [:zrhoffman]]

This will require passing the computed::Context's StyleBuilder all the way to properties_and_values::ComputedValue::compute.

Comment 1

[Tess Hoffman [:zrhoffman]]

In order to call Cascade::apply_prioritary_properties while the computed::Context is borrowed from the CustomPropertiesBuilder, the computed::Context will probably need to be passed as an argument instead of the Cascade having a context field.

Comment 2

[Tess Hoffman [:zrhoffman]]

Attachment: Bug 1856524 - [css-properties-values-api] Compute <length> and <length-percentage>. r=zsun,fredw,#style

Now that registered custom properties containing font-relative units are
calculated accurately, the two syntaxes tending to use font-relative
units the most, <length> and <length-percentage>, can be computed.

Depends on D194023

Comment 3

[Tess Hoffman [:zrhoffman]]

Unassigning since D194024 is not landing yet.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a35aa51e1bfc
[css-properties-values-api] Compute <length> and <length-percentage>. r=firefox-style-system-reviewers,emilio

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/a35aa51e1bfc