Closed Bug 1846822 Opened 1 year ago Closed 1 year ago

wpt canvas tests don't appear to run with D2D

Categories

(Core :: Graphics: Canvas2D, defect, P2)

defect

Tracking

()

RESOLVED FIXED
118 Branch
Tracking Status
firefox118 --- fixed

People

(Reporter: jrmuizel, Assigned: jmaher)

References

(Depends on 1 open bug)

Details

Attachments

(1 file)

I noticed this because of bug 1846613

Severity: -- → S2
Priority: -- → P2
Blocks: 1846613

is this linux/windows/mac/android? IIRC d2d is windows...

are there prefs we need to set or different drivers that are needed?

Flags: needinfo?(jmuizelaar)

This is Windows only.

We need to run the tests on VMs with a GPU. I believe we're currently not doing that.

Flags: needinfo?(jmuizelaar)

which tests are wpt canvas? a certain set of directories? I saw in the other bug a reference to mochitest test_canvas.html as well. any tips for how to query a list of tests to run with a gpu would be good.

(In reply to Joel Maher ( :jmaher ) (UTC -8) from comment #3)

which tests are wpt canvas? a certain set of directories?

Everything under testing/web-platform/tests/html/canvas/ should run on a Windows GPU instance.

Depends on: 1846925
No longer depends on: 1846925
See Also: → 1846883

here is a try push with canvas tests split out (so we can ensure they run on gpu for windows:
https://treeherder.mozilla.org/jobs?repo=try&tier=1%2C2%2C3&revision=65f4b2b68bea0809dff82c452da6666efbeb0fd6

a lot of failures- those will need to be addressed.

:jrmuizel, should we just change the annotations, or is there work to do?

Flags: needinfo?(jmuizelaar)

How about we land it with the annotations changed and then do an audit afterwards?

Flags: needinfo?(jmuizelaar) → needinfo?(jmaher)

ok, I will green this up and get a patch for review, then the canvas team can follow up as time permits to address anything

Flags: needinfo?(jmaher)

Thanks

Assignee: nobody → jmaher
Status: NEW → ASSIGNED
Depends on: 1847850
Pushed by jmaher@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/42a4b2af2922 Run wpt html/canvas tests on gpu. r=jrmuizel,aryx
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 118 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: