1846613 - Chart elements are rendered incorrectly on chartjs.org

Status: VERIFIED FIXED

(Core :: Graphics: Canvas2D, defect)

Description

[Ksenia Berezina [:ksenia]]

Attachment: chartjs.png

This was originally reported in https://github.com/webcompat/web-bugs/issues/124731

To reproduce, visit https://www.chartjs.org/docs/latest/samples/bar/border-radius.html in Firefox Nightly or release on Windows

Expected:
Vertical bar charts are displayed with 2 border radius variations

Actual:
Border radius is applied incorrectly

Note: The issue is not reproducible on MacOS.

From mozregression:
Differential Revision: https://phabricator.services.mozilla.com/D181542
2023-08-01T17:00:51.622000: DEBUG : Did not find a branch, checking all integration branches
2023-08-01T17:00:51.623000: INFO : The bisection is done.
2023-08-01T17:00:51.624000: INFO : Stopped

Comment 1

[Ksenia Berezina [:ksenia]]

Hello Jeff, wonder if you could take a look at this, please?

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1839470

Comment 3

[Jeff Muizelaar [:jrmuizel]]

It looks like bug 1839470 exposed an existing bug in PathD2D::Arc

Comment 4

[Lee Salzman [:lsalzman]]

It seems like mochitest test_canvas.html is not enabled on Windows either, which is where we have a lot of canvas arc coverage. I wonder if those would have caught the bug. It looks like bug 1464181 disabled those, during the early WebRender development era (the mochitest.ini line implicates bug 1464173, though the actual change was bug 1464181).

Comment 5

[Jeff Muizelaar [:jrmuizel]]

Attachment: Bug 1846613. Use ArcToBezier for D2D until the D2D Arc bugs are fixed.

This should roughly approximate the behaviour we had prior to bug 1839470

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/244b15e6eeb5
Use ArcToBezier for D2D until the D2D Arc bugs are fixed. r=ahale

Comment 7

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 9347035 [details]
Bug 1846613. Use ArcToBezier for D2D until the D2D Arc bugs are fixed.

Beta/Release Uplift Approval Request

• User impact if declined: We'll sometimes draw arcs in canvas the wrong way.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This makes us use the same ArcToBezier path for arcs that we were previously using directly in canvas. It has been manually verified to fix the chartjs issue.
• String changes made/needed:
• Is Android affected?: No

Comment 8

[Dianna Smith [:diannaS]]

Comment on attachment 9347035 [details]
Bug 1846613. Use ArcToBezier for D2D until the D2D Arc bugs are fixed.

Approved for 117.0b3
Approved for 116.0.1 dot release

Comment 9

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/65512c991660

Comment 10

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/00e19a9cda56

Comment 11

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/244b15e6eeb5

Comment 12

[Timothy Nikkel (:tnikkel)]

Attachment: minimal testcase

The two arcs should look the same.

Comment 16

[Anca Soncutean, Desktop QA]

Reproduced with Fx 118.0a1 (2023-08-02).
Verified fixed with Fx 118.0a1 (2023-08-03), 117.0b3 and 116.0.1.
Tested on Windows 10.