Closed
Bug 1846883
Opened 1 year ago
Closed 1 year ago
Run test_canvas on gpu instances.
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
RESOLVED
FIXED
118 Branch
People
(Reporter: jrmuizel, Assigned: jrmuizel)
References
Details
Attachments
(1 file)
48 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
RyanVM
:
approval-mozilla-release+
RyanVM
:
approval-mozilla-esr115+
|
Details | Review |
This reenables test_canvas on Windows and runs it on a GPU
instance so that we actually test the D2D code.
This test would've caught the regression in bug 1846613
Assignee | ||
Comment 1•1 year ago
|
||
This reenables test_canvas on Windows and runs it on a GPU
instance so that we actually test the D2D code.
This test would've caught the regression in bug 1846613
Pushed by jmuizelaar@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9836af94c959
Run test_canvas on gpu instances. r=RyanVM
Assignee | ||
Comment 3•1 year ago
|
||
Comment on attachment 9347063 [details]
Bug 1846883 - Run test_canvas on gpu instances.
Beta/Release Uplift Approval Request
- User impact if declined: The possibility of regressions with Direct2D canvas that we don't catch
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: Bug 1846613
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): This is a testing manifest only change. It has no risk
- String changes made/needed:
- Is Android affected?: No
ESR Uplift Approval Request
- If this is not a sec:{high,crit} bug, please state case for ESR consideration: This will help us avoid shipping regressions to ESR
- User impact if declined: The possibility of regressions with Direct2D canvas that we don't catch
- Fix Landed on Version: 118
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): This is a testing manifest only change. It has no risk
Attachment #9347063 -
Flags: approval-mozilla-release?
Attachment #9347063 -
Flags: approval-mozilla-esr115?
Attachment #9347063 -
Flags: approval-mozilla-beta?
Comment 4•1 year ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox118:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 118 Branch
Comment 6•1 year ago
|
||
Comment on attachment 9347063 [details]
Bug 1846883 - Run test_canvas on gpu instances.
Doesn't technically need approval since it's test-only, but a=me regardless.
Attachment #9347063 -
Flags: approval-mozilla-release?
Attachment #9347063 -
Flags: approval-mozilla-release+
Attachment #9347063 -
Flags: approval-mozilla-esr115?
Attachment #9347063 -
Flags: approval-mozilla-esr115+
Attachment #9347063 -
Flags: approval-mozilla-beta?
Attachment #9347063 -
Flags: approval-mozilla-beta+
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/releases/mozilla-beta/rev/fe92297b9865
Run test_canvas on gpu instances. r+a=RyanVM
Updated•1 year ago
|
status-firefox117:
--- → fixed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/releases/mozilla-release/rev/abbacad8c3f0
Run test_canvas on gpu instances. r+a=RyanVM
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/releases/mozilla-esr115/rev/68bdc41e5057
Run test_canvas on gpu instances. r+a=RyanVM
Updated•1 year ago
|
status-firefox116:
--- → fixed
status-firefox-esr115:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•