1846837 - Bug 1727181 broke overriding domain in message ID with identity pref "FQDN"

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[betterbird.project+8]

+++ This bug was initially created as a clone of Bug #1727181 +++

Bug 1727181 broke overriding domain in message ID with identity pref "FQDN".

Comment 1

[Alessandro Castellani [:aleca]]

Brendan, can you investigate this?

Comment 2

[betterbird.project+8]

https://github.com/Betterbird/thunderbird-patches/blob/main/115/bugs/1846837-fix-FQDN.patch

Comment 3

[Brendan Abolivier [:babolivier]]

Attachment: Bug 1846837 - Use the FQDN identity attribute to generate Message-Id headers, if set. r=#thunderbird-reviewers

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e53b4aa93adc
Use the FQDN identity attribute to generate Message-Id headers, if set. r=mkmelin

Comment 5

[Brendan Abolivier [:babolivier]]

Comment on attachment 9360184 [details]
Bug 1846837 - Use the FQDN identity attribute to generate Message-Id headers, if set. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): bug 1727181
User impact if declined: Newsgroups users using the FQDN identity attribute see messages sent to newsgroups sent with a Message-Id header using an incorrect domain.
Testing completed (on c-c, etc.): On c-c
Risk to taking this patch (and alternatives if risky): None that I can think of. I don't believe the code changed by this patch has been changed since bug 1727181 (which has already been uplifted to ESR).

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9360184 [details]
Bug 1846837 - Use the FQDN identity attribute to generate Message-Id headers, if set. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 7

[Rob Lemley [:rjl]]

This will need an esr115 patch due to bug 1854255 (ef6629fe1cb953).

Comment 8

[Rob Lemley [:rjl]]

Actually a beta patch would be helpful too since ef6629fe1cb953 is not on beta and I'd rather not uplift it.

Comment 9

[Brendan Abolivier [:babolivier]]

Attachment: Bug 1846837 - Use the FQDN identity attribute to generate Message-Id headers, if set (ESR + beta). r=#thunderbird-reviewers

Also update the message ID generation to use nsACString instead of raw strings.

This is https://phabricator.services.mozilla.com/D191842 but rebased to be uplifted to ESR and beta.

Comment 10

[Brendan Abolivier [:babolivier]]

Since both beta and ESR are blocked by the same commit, I've made a patch that should cover both of them. Let me know if you need separate patches for each version.

I'm not sure whether this patch needs review since there's little to no change to the original patch that landed on c-c.

Comment 11

[Rob Lemley [:rjl]]

Comment on attachment 9362802 [details]
Bug 1846837 - Use the FQDN identity attribute to generate Message-Id headers, if set (ESR + beta). r=#thunderbird-reviewers

This is for the beta/esr version of the patch. D193193
[Triage Comment]
Previously approved for beta

[Approval Request Comment]
Regression caused by (bug #): bug 1727181
User impact if declined: Newsgroups users using the FQDN identity attribute see messages sent to newsgroups sent with a Message-Id header using an incorrect domain.
Testing completed (on c-c, etc.): On c-c
Risk to taking this patch (and alternatives if risky): None that I can think of. I don't believe the code changed by this patch has been changed since bug 1727181 (which has already been uplifted to ESR).

Comment 12

[Daniel Darnell [:dandarnell]]

Thunderbird 120.0b6:
https://hg.mozilla.org/releases/comm-beta/rev/ba0def569fb4

Comment 13

[Wayne Mery (:wsmwk)]

Comment on attachment 9362802 [details]
Bug 1846837 - Use the FQDN identity attribute to generate Message-Id headers, if set (ESR + beta). r=#thunderbird-reviewers

[Triage Comment]
Approved for esr115

Comment 14

[Rob Lemley [:rjl]]

Thunderbird 115.5.0:
https://hg.mozilla.org/releases/comm-esr115/rev/3eeec9886950