1847141 - Downloading images from any website is causing com.android.phone to crash

Status: VERIFIED FIXED

(Fenix :: Downloads, defect, P1)

Description

[Ved]

Attachment: Image showing successful download message in the background, the crash message on the foreground

User Agent: Mozilla/5.0 (Android 10; Mobile; rv:109.0) Gecko/118.0 Firefox/118.0
Firefox for Android

Steps to reproduce:

Visit any website, long press on am image, save image

Actual results:

Image got saved, Firefox doesn't crash, but weirdly com.android.phone crashes causing a temporary loss of mobile network

Expected results:

No effect on Android Phone application

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Networking' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Adina Petridean]

Hello!

I was not able to reproduce the issue using the latest Nightly build (118.0a1) from 8th of August 2023. Tested with 2 devices:

Google Pixel 7 Pro (Android 14)
Motorola Moto G9 plus (Android 11)

We would need more information regarding the ticket:
What's the model of the device you were using when you encountered the issue?
Could you send us a video regarding the issue you've faced?

Please see if you still reproduce the issue with other images as well, or maybe, if you can, clear your data before to see if some setting might have interfered with how the image appears.
Thank you!

Comment 3

[Ved]

I'm using Nightly 118.0a1 (Build #2015966755) on Android 10, Samsung Galaxy Note9. In the attached video, I've tried the most generic image and it still crashed the phone app. I also used normal tab, to make sure the issue was not with Private tab.
I'm a bit hesitant to clear data (hopefully the last-resort option) and start setting up from scratch as the settings have worked for me all these months and it takes time to set it all back and it only started crashing very recently. I would be glad to get you the logs if it can't be reproduced elsewhere.

Comment 4

[Ved]

Attachment: Recording showing crash

Comment 5

[jackyzy823]

It would be helpful if you could provide the log.

Comment 6

[Ved]

Attachment: logcat of the crash

Have attached the logcat with a crash buffer to minimize the entries. I have a pretty basic understanding of the logcat environment, so if complete logs are required, I will put that up as well

Comment 7

[Ved]

I had a look at the other bug filed as well. And since the bug couldn't be reproduced in either of the two phones mentioned, it could be something limited to earlier version of Android and/or Samsung phones, which could be narrowed once more information from the other bug filee is obtained

Comment 8

[jackyzy823]

Thanks for the log, it looks like the brodcast intent is wrongly captured by CarrierKeyDownloadManager and the brodcast intent contains serializable object which CarrierKeyDownloadManager cannot instantiate the object.

This could be device-specified. Accoring to AOSP , CarrierKeyDownloadManager has a filter and should not receive this intent https://cs.android.com/android/platform/superproject/main/+/main:frameworks/opt/telephony/src/java/com/android/internal/telephony/CarrierKeyDownloadManager.java;l=122-124?q=CarrierKeyDownloadManager&ss=android%2Fplatform%2Fsuperproject%2Fmain

However , it should be Fenix's duty to not contain serializable object in a brodcast intent? Fix maybe either making DownloadState.Status enum Parcelable or passing enum's value in intent.

Comment 9

[Ved]

Anyway I can do that and stop the crash? Or wait for an update?

Comment 10

[jackyzy823]

I'm not sure. Maybe you could try setting default dialer app to alternative one (like third party dialer).

Since code from Fenix part has been there for a long while ( more than 3 years). i'm not sure why it start causing crash recently.

Does the android os update recently?

Comment 11

[Ved]

I already use Google Dialer, ditching the inbuilt Samsung one
And this phone has reached EOS, so no security updates either. No idea what triggered it all of a sudden

Comment 12

[jackyzy823]

I guess bug 1839366 is the regression of this bug because it changed visibility of intent here https://github.com/mozilla-mobile/firefox-android/commit/1ea20c146103b547820c6204da7022f2d27a7a2c#diff-461a397023312e6d2b9e3969eb2a95e039c43a25a163ab0b35fbbff81cdf2c81L841

Comment 14

[jackyzy823]

Info from giwayume in bug 1847691 :

This error doesn't happen when I turn off mobile data on the phone and only use wifi, by the way.

and device is Pixel 3a XL

Comment 15

[Mihai Adrian Carare [:mcarare]]

The change made the intent visible for other apps, but it would be the other app's responsibility to correctly handle the received intents that they listen to.
We do use this pattern in other places in the app.

We could limit the broadcast to our own process and that could prevent other apps crashing when not handling the intent extra correctly.

Comment 16

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1847141 - Restrict download broadcasts to app process. (#3191)

Comment 17

[Ved]

Can this build from mentioned git be installed and used or do I need to wait for it to be merged and pushed from play store?

Comment 18

[jackyzy823]

It could be installed , but not recommend since it will be installed as another Firefox browser: Firefox Fenix (App name) with package name "org.mozilla.fenix.debug"

I'd recommend you to wait for it to be merged.

Comment 19

[Ved]

I did go ahead and install the test build. The crash has stopped and the Firefox Preview logo is really rad!

Comment 20

[Jenci]

I have a same issue on Sony Xperia XZ2 (Android 10) device.

Comment 22

[Cameron Dean]

I was facing the same issue at one of my post https://nationalday.blog/world-gratitude-day-quotes-and-sayings/ and later i solved it with the help of my friend and i want to suggest you some of the following methods,
Clear Cache: Clear the cache of the "com.android.phone" app from your device's settings.
Update Apps: Ensure that your Android operating system and all apps are updated to their latest versions.
Check Storage: Make sure you have enough free storage space on your device.
Safe Mode: Boot your device in safe mode to check if any third-party apps are causing the issue.
Factory Reset: As a last resort, you can perform a factory reset, but remember to back up your data before doing so.

Comment 23

[Daniel Mcge]

I already face this issue at https://12thclassresult.pk/ and if someone know how to fix it please help me too

Comment 24

[BMO Github Automation]

Authored by https://github.com/mcarare
https://github.com/mozilla-mobile/firefox-android/commit/724f9a64ed42fe11f4c3c88b1e433df09cc3b6ee
[main] Bug 1847141 - Suppress UnspecifiedRegisterReceiverFlag for SDK < 33

Authored by https://github.com/mcarare
https://github.com/mozilla-mobile/firefox-android/commit/24947fe28fe8fb5037403ac807923f1d2b2ebfff
[main] Bug 1847141 - Restrict receiving download broadcasts.

Comment 25

[miralobontiu]

Verified as fixed on the latest Fenix Nightly 119.0a1 from 9/6 with Sony Xperia Z5 Premium (Android 7.1.1).

I was able to reproduce the issue on the RC 117.0 build with the same device.

Comment 26

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:mcarare, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval. Also, don't forget to request an uplift for the patches in the regression caused by this fix.
• If no, please set status-firefox118 to wontfix.

For more information, please visit BugBot documentation.

Comment 27

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1847141 - Remove hardcoding of RECEIVE_DOWNLOAD_BROADCAST_PERMISSION (#3534)

Comment 28

[BMO Github Automation]

Authored by https://github.com/mcarare
https://github.com/mozilla-mobile/firefox-android/commit/6f0165bdee10df149229434713fb4321708693bf
[main] Bug 1847141 - Remove hardcoding of RECEIVE_DOWNLOAD_BROADCAST_PERMISSION

Comment 30

[jackyzy823]

Hello devs, i think this bug is important enough to require an uplift. Because this bug causes users' phone Celular network down. It is quite a serious issue.

Comment 32

[Ryan VanderMeulen [:RyanVM]]

This fix already caused a pretty severe regression (which yesterday's follow-up fixed). I agree that the impact of this bug probably warrants a backport to v118, though. Let's give it a bit more time to bake and then we can revisit. Thanks for following up, jackyzy823!

Comment 34

[Pascal Chevrel:pascalc]

Last beta builds today, Mihai is that a wontfix for 118?

Comment 35

[Mihai Adrian Carare [:mcarare]]

My opinion is that a backport is risky at this point. The issue caused by the initial fix seemed worse ( not being able to update the app) than the current issue, also taking into consideration the small number of reports. Is a future dot release planned? Could this be included at that point?

Comment 36

[Pascal Chevrel:pascalc]

We have a planned dot release mid-cycle.

Comment 37

[Mihai Adrian Carare [:mcarare]]

Then I think we should consider adding this to that dot release, if no further issues are reported for the current fix.

Comment 38

[Ryan VanderMeulen [:RyanVM]]

This should be left as fix-optional then. If it's set to wontfix, it won't appear in any bug queries down the road.

Comment 41

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1847141 - Restrict receiving download broadcasts. (#3746)

Comment 42

[Mihai Adrian Carare [:mcarare]]

Comment on attachment 9354502 [details] [review]
[mozilla-mobile/firefox-android] Bug 1847141 - Restrict receiving download broadcasts. (#3746)

Beta/Release Uplift Approval Request

• User impact if declined: Some devices might have issues as apps try to handle the broadcast intent from Firefox and fail to do so. This fix prevents other apps from receiving the broadcast.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Medium
• Why is the change risky/not risky? (and alternatives if risky):
• String changes made/needed:
• Is Android affected?: Yes

Comment 44

[Pascal Chevrel:pascalc]

Comment on attachment 9354502 [details] [review]
[mozilla-mobile/firefox-android] Bug 1847141 - Restrict receiving download broadcasts. (#3746)

Although this is evaluated as medium risk, this was verified on nightly, is now on beta and no new regressions were reported, let's take it into our next Android dot release, thanks.

Comment 45

[BMO Github Automation]

Authored by https://github.com/mcarare
https://github.com/mozilla-mobile/firefox-android/commit/32491a2824dab037f67ac9c38b3b96c17953422e
[releases_v118] Bug 1847141 - Restrict receiving download broadcasts by other apps

Comment 46

[miralobontiu]

I was not able to trigger a crash by downloading images on several websites.
Tested on the lates RC 118.1.1 build 1 with Sony Xperia Z5 Premium (Android 7.1.1).