1847432 - ctrl+shift+K stops working

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Wayne Mery (:wsmwk)]

ctrl+shift+K to invoke quick filter randomly stops working. Mac 117 beta.

Probably predates 115. I don't know how to reproduce. Nothing obvious in error console. It's happened a few times this year. Only a restart restores function.

Related to Bug 1763655? Quickfilter (ctrl+shift+k) does not work / does not show searchable items

Comment 1

[Wayne Mery (:wsmwk)]

Attachment: keyboard log

I still have no clue what is triggering this.

I started the log, hit ctrl+shift+K, then shut down Thunderbird.

Comment 2

[Magnus Melin [:mkmelin]]

I haven't seen anything on linux. I guess Mac specific? The log looks like there's some kind of infinite loop going on there.

Maybe from something from the recent checkins for https://hg.mozilla.org/mozilla-central/log/tip/widget/cocoa/TextInputHandler.mm

Comment 3

[Wayne Mery (:wsmwk)]

Seen again in recent weeks

Comment 4

[Wayne Mery (:wsmwk)]

still happens (on Mac)

Comment 5

[Ralf Jung]

I'm seeing this on Linux, too (Bug 1921469).

Comment 7

[Ralf Jung]

Just had this again with 128.6.0esr. It's quite dangerous since I will type "Ctrl-Shift-K <filter text here>", and now Thunderbird interprets the filter text as shortcuts, so e.g. if it contains a "J" I am marking a random email as junk -- the actions accidentally performed this way can be non-trivial to un-do.

What kind of debug information would be helpful? I see nothing in the error console.

Comment 8

[Wayne Mery (:wsmwk)]

(In reply to Wayne Mery (:wsmwk) from comment #4)

still happens (on Mac)

I've seen this a few times more in the last couple years.

(In reply to Ralf Jung from comment #7)

...
What kind of debug information would be helpful? I see nothing in the error console.

Don't know.

mstange any ideas?

Comment 9

[u793314]

Happened to me the first time today (long-time user). Ubuntu 24 LTS, Thunderbird 153.0.

Comment 10

[Ralf Jung]

This is still a problem with 153.0.3esr.

Comment 11

[neatsorg]

I found reliable steps to reproduce and the likely cause (Thunderbird 158.0, Linux/Wayland).
No extensions are needed.

STR:

1. In a mail tab, press Ctrl+Shift+K -> the Quick Filter Bar toggles as expected.
2. Open any content tab: Tools > Add-ons and Themes, Settings, or Account Settings.
3. Switch back to the mail tab (click the tab or Ctrl+Tab).
4. Press Ctrl+Shift+K -> nothing happens.

Switching back from the Calendar tab does NOT break it. Switching to the Calendar tab
and then back to the mail tab makes the shortcut work again.

Cause: key_qfb_show is bound to <command id="cmd_showQuickFilterBar">. The command gets
disabled while a content tab is selected, and nothing re-evaluates it when you return
to a mail tab. Running this in the Browser Console restores the shortcut:

Services.wm.getMostRecentWindow("mail:3pane").goUpdateCommand("cmd_showQuickFilterBar")

The Calendar tab doesn't have this problem because calendarTabMonitor.onTabSwitched()
calls calendarController2.updateCommands(), which includes cmd_showQuickFilterBar,
when leaving the calendar/task tab. A mail tab probably needs to re-evaluate this
command (and maybe cmd_toggleQuickFilterBar) in its showTab/onTabSwitched.

Workaround: bind ctrl+shift+k to "cmd:cmd_showQuickFilterBar" with tbkeys-lite.
goDoCommand() checks the controllers directly, so the stale disabled state is bypassed.

Comment 12

[Hartmut Welpmann [:welpy-cw]]

Attachment: Bug 1847432 - Refresh command state when the command context changes. r=mkmelin

Refresh mail and calendar command sets after tab selection, active mail-tab
loading, and Account Hub closure using a shared command-context-changed
update. Guard folder-pane readiness during startup and document command
updates.

Update New Message when account identities are added or accounts are removed,
and refresh tag commands when opening the Tag popup.

Add regression coverage for tab changes and loading, Quick Filter keyboard
focus, first-account setup and identity changes, and Tag popup actions.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/512e24afbcf0
Refresh command state when the command context changes. r=mkmelin