1847809 - Pressing ctrl+s sometimes produces a whole bunch of save dialogs instead of just one

Status: RESOLVED DUPLICATE of bug 1774062

(Core :: Widget: Gtk, defect)

Description

[firstmatedavy]

Attachment: Screenshot from 2023-08-08 20-16-28.png

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/115.0

Steps to reproduce:

I am using Firefox that came bundled with the Ubuntu 22.04 installer.

I press ctrl+p to open up the print dialog. Print to PDF was selected by default because I do not have a printer paired. Then I pressed ctrl+s (hoping it was a shortcut to save the file, because it take a lot of tabbing to move focus to the save button).

Actual results:

A save dialog opened for the HTML page that was open, prompting to save the page as an HTML file. The save dialog could not be dismissed - I tried clicking save, clicking close, pressing the escape key, and clicking outside of the dialog. I could open new browser windows, but could not get rid of the print and save dialogs to make the tabs on the current window accessible again.

I was able to make this happen while printing a couple different websites, and it seems to happen consistently.

Expected results:

Anything but that, lol.

Some potential better behaviors

• Save dialog is dismissable (with close and/or escape key)
• Ctrl+s disabled while print dialog is open (to prevent getting stuck in the save dialog)
• Ctrl+s saves the file in the print preview is the behavior I'd hoped for, but on reflection that could be a problem for people who have different expectations and an actual printer with expensive ink hooked up.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Printing: Output' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[David Shin[:dshin]]

Thanks for filing!

Hm, on 20.04, I can't seem to reproduce this, even on Nightly 115, on bearblog.dev.
Even if the print dialog is open, the save dialog could be dismissed with escape key/close button.
Is there any printing-specific pref you've enabled in about:config? Does this happen when launched with a fresh profile through about:profiles?

Comment 3

[Daniel Holbert [:dholbert]]

I can reproduce, using Firefox 22.04 with snappified Firefox (i.e. /usr/bin/firefox that ships with Ubuntu, at least in Ubuntu 22.04 and newer).

It doesn't have anything to do with the print dialog, though. I can reproduce with just Ctrl+S while viewing https://example.org . (The first time I do it, I usually just get one save dialog; but if I dismiss it and try again, I was able to reproduce it that time. This happened in two consecutive browsing sessions.)

It seems like the issue is that file-save dialogs just keep appearing over and over and over again, and if you close one, there's a stack of ~tens more underneath. If you hold down the Esc key, then you might eventually clear all of them. So: the browser isn't frozen exactly; it's just covered up by a large stack of redundant dialogs.

I suspect this is a snap-specific issue. I can't reproduce this in Firefox release direct from Mozilla. (Also, the save dialog looks a little bit different there.)

Comment 4

[Daniel Holbert [:dholbert]]

I can reproduce this with the File-Open dialog as well. I'm using Firefox 116.0.3 (the Ubuntu-provided snap)

Simpler STR:
(1) While viewing any web page, hold Ctrl+S for a few seconds, or hold Ctrl+O for a few seconds. (Doesn't have to be very long, but be sure you're still holding it for a little bit after the save or open dialog appears.)

ACTUAL RESULTS:
Infinite save/open dialogs keep spawning and claiming focus.

EXPECTED RESULTS:
Just one dialog.

Comment 5

[Daniel Holbert [:dholbert]]

This might be the same thing that was reported in bug 1811989.

Comment 6

[Daniel Holbert [:dholbert]]

Attachment: screencast of bug

Here's a screencast of the bug.

While capturing this screencast, I also captured a Firefox profile. Here's that profile:
https://share.firefox.dev/44n6Ofi

(The profile is missing symbols right now, but I can try go get them added later via samply.)