1774062 - Ctrl+S and Ctrl+O shortcut-keys trigger too many XDG portal window when running on Xwayland, leading to resources exhaustion

Status: NEW

(Firefox Build System :: Third Party Packaging, defect, P2)

Description

[earl.potters]

Attachment: Screenshot from 2022-06-13 12-27-36.png

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:101.0) Gecko/20100101 Firefox/101.0

Steps to reproduce:

System: Linux 5.15.0-37-generic #39-Ubuntu 22.04 GNU/Linux
Firefox version: 101.0.1

Spamming CTRL-S on Firfox current window

Actual results:

Firefox freezes current window

Expected results:

Not Freeze

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Widget: Gtk' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[:gerard-majax]

We indeed trigger too many XDG portal file save dialog, I am unsure whether this is an issue on our side or elsewhere.

Comment 3

[:gerard-majax]

Do you repro that on a nightly from edge channel on snap ? It seems nightly does not exhibit this behavior.

Comment 4

[:gerard-majax]

STRs are a bit worse for me:

• Open a webpage
• CTRL+S, then Escape
• CTRL+S again, maybe twice quickly?

Expected:
One XDG portal window open

Actual:
The shadow around the XDG portal window increases to black, advocating we have many opened.

It's mostly 100% reliable. No repro on Nightly, or on MOZ_ENABLE_WAYLAND=1 firefox so it seems to be due to XWayland

Comment 5

[earl.potters]

I have been able to fix my issue by changing WAYLAND to XORG display server.

I don't know if Firefox has current issues with Wayland

Comment 9

[:gerard-majax]

Nightly and forcing DISABLE_WAYLAND=1 MOZ_ENABLE_WAYLAND=0 snap run firefox I can't reproduce.

Comment 10

[:gerard-majax]

Reproduced and logging on https://searchfox.org/mozilla-central/rev/5a49163b7012ded5fa1c4da5aa4f8d3f7c85a5e7/widget/gtk/nsFilePicker.cpp#349 shows a are hitting this code path each time a new portal is spawn, so whatever is happening seems to be triggered by us :(

Comment 11

[:gerard-majax]

And logging shows spam of OnKeyPressEvent as well as key_press_event_cb: https://searchfox.org/mozilla-central/rev/5a49163b7012ded5fa1c4da5aa4f8d3f7c85a5e7/widget/gtk/nsWindow.cpp#8227

Comment 12

[:gerard-majax]

With GTK_DEBUG=all I get something?

13:57:51.141 -> keycode=37 modifiers=0x0000 keyval=65507 group=0 level=0 consumed_modifiers=0x6002
13:57:51.392 -> keycode=39 modifiers=0x0004 keyval=115 group=0 level=0 consumed_modifiers=0x6083
13:57:51.662 -> keycode=39 modifiers=0x0004 keyval=115 group=0 level=0 consumed_modifiers=0x6083
[...]
13:57:56.539 -> keycode=37 modifiers=0x0000 keyval=65507 group=0 level=0 consumed_modifiers=0x6002
13:57:56.999 -> keycode=39 modifiers=0x0004 keyval=115 group=0 level=0 consumed_modifiers=0x6083
13:57:57.164 -> keycode=39 modifiers=0x0004 keyval=115 group=0 level=0 consumed_modifiers=0x6083
13:57:57.242 -> keycode=39 modifiers=0x0004 keyval=115 group=0 level=0 consumed_modifiers=0x6083
13:57:57.768 -> keycode=39 modifiers=0x0004 keyval=115 group=0 level=0 consumed_modifiers=0x6083
13:57:57.898 -> keycode=39 modifiers=0x0004 keyval=115 group=0 level=0 consumed_modifiers=0x6083
13:57:58.098 -> keycode=39 modifiers=0x0004 keyval=115 group=0 level=0 consumed_modifiers=0x6083
13:57:58.098 -> keycode=39 modifiers=0x0004 keyval=115 group=0 level=0 consumed_modifiers=0x6083
13:57:58.099 -> keycode=39 modifiers=0x0004 keyval=115 group=0 level=0 consumed_modifiers=0x6083
13:57:58.203 -> keycode=39 modifiers=0x0004 keyval=115 group=0 level=0 consumed_modifiers=0x6083
13:57:58.349 -> keycode=39 modifiers=0x0004 keyval=115 group=0 level=0 consumed_modifiers=0x6083
13:57:58.353 -> keycode=39 modifiers=0x0004 keyval=115 group=0 level=0 consumed_modifiers=0x6083
13:57:58.353 -> keycode=39 modifiers=0x0004 keyval=115 group=0 level=0 consumed_modifiers=0x6083
13:57:58.354 -> keycode=39 modifiers=0x0004 keyval=115 group=0 level=0 consumed_modifiers=0x6083
13:57:58.354 -> keycode=39 modifiers=0x0004 keyval=115 group=0 level=0 consumed_modifiers=0x6083
13:57:58.638 -> keycode=39 modifiers=0x0004 keyval=115 group=0 level=0 consumed_modifiers=0x6083
13:57:58.638 -> keycode=39 modifiers=0x0004 keyval=115 group=0 level=0 consumed_modifiers=0x6083
13:57:58.638 -> keycode=39 modifiers=0x0004 keyval=115 group=0 level=0 consumed_modifiers=0x6083
13:57:58.638 -> keycode=39 modifiers=0x0004 keyval=115 group=0 level=0 consumed_modifiers=0x6083
13:57:58.740 -> keycode=39 modifiers=0x0004 keyval=115 group=0 level=0 consumed_modifiers=0x6083
13:57:58.742 -> keycode=39 modifiers=0x0004 keyval=115 group=0 level=0 consumed_modifiers=0x6083
13:57:58.864 -> keycode=39 modifiers=0x0004 keyval=115 group=0 level=0 consumed_modifiers=0x6083
13:57:59.244 -> keycode=39 modifiers=0x0004 keyval=115 group=0 level=0 consumed_modifiers=0x6083
13:57:59.244 -> keycode=39 modifiers=0x0004 keyval=115 group=0 level=0 consumed_modifiers=0x6083
13:57:59.245 -> keycode=39 modifiers=0x0004 keyval=115 group=0 level=0 consumed_modifiers=0x6083
13:57:59.245 -> keycode=39 modifiers=0x0004 keyval=115 group=0 level=0 consumed_modifiers=0x6083
13:57:59.348 -> keycode=39 modifiers=0x0004 keyval=115 group=0 level=0 consumed_modifiers=0x6083
13:57:59.476 -> keycode=39 modifiers=0x0004 keyval=115 group=0 level=0 consumed_modifiers=0x6083
13:57:59.976 -> keycode=39 modifiers=0x0004 keyval=115 group=0 level=0 consumed_modifiers=0x6083
13:57:59.981 -> keycode=39 modifiers=0x0004 keyval=115 group=0 level=0 consumed_modifiers=0x6083
13:57:59.982 -> keycode=39 modifiers=0x0004 keyval=115 group=0 level=0 consumed_modifiers=0x6083
13:57:59.982 -> keycode=39 modifiers=0x0004 keyval=115 group=0 level=0 consumed_modifiers=0x6083

First three lines are a first attempt, unsuccessfull. Upon the second attempts, I pressed a few times again and reproduced. Over all, the log for a few seconds contains 136 occurrences of those keycode = 39 lines.

Comment 13

[:gerard-majax]

Attachment: ctrl_s_gtk.zip

Comment 14

[:gerard-majax]

Attachment: Two/three consecutive quick CTRL+s

This is direct output, performing only two/three consecutive CTRL+s on the keyboard.

Comment 15

[:gerard-majax]

Disabling "Key repeat" in GNOME Control Center's Accessibility menu (Universal Access > Typing > Repeat Keys), I cannot reproduce anymore. This is one of the documented STR of https://github.com/ueno/ibus-skk/issues/64 being referenced by https://gitlab.gnome.org/GNOME/mutter/-/issues/203.

As soon as I enable again the feature, I can reproduce.

Comment 16

[:gerard-majax]

This code should prevent us from doing bad things https://searchfox.org/mozilla-central/rev/fadd0a14d2a2724ee4733ef73970a2ddd457a43f/widget/gtk/nsFilePicker.cpp#351, but I can see we dont hit https://searchfox.org/mozilla-central/rev/fadd0a14d2a2724ee4733ef73970a2ddd457a43f/widget/gtk/nsFilePicker.cpp#515 when the issue reproduces.

Comment 17

[:gerard-majax]

(In reply to Alexandre LISSY :gerard-majax from comment #16)

This code should prevent us from doing bad things https://searchfox.org/mozilla-central/rev/fadd0a14d2a2724ee4733ef73970a2ddd457a43f/widget/gtk/nsFilePicker.cpp#351, but I can see we dont hit https://searchfox.org/mozilla-central/rev/fadd0a14d2a2724ee4733ef73970a2ddd457a43f/widget/gtk/nsFilePicker.cpp#515 when the issue reproduces.

This is simply because we get actual CTRL+s events so we issue a whole new flow of "Save as" from https://searchfox.org/mozilla-central/rev/fadd0a14d2a2724ee4733ef73970a2ddd457a43f/toolkit/content/contentAreaUtils.js#108-151

Comment 18

[:gerard-majax]

Amin, what can we do to move forward on that issue ?

Comment 22

[Daniel Holbert [:dholbert]]

For what it's worth: this reproduces in flatpak-installed Firefox as well (on Ubuntu 22.04 at least).