1848834 - Now since columns like Size, Unread and Total are aligned right values should not be placed under Column Picker

Status: RESOLVED FIXED

(Thunderbird :: Message Reader UI, enhancement)

Description

[[e-mail]]

Attachment: thread columns right aligned under column picker

Since #184604 has landed now right aligned numbers are placed under 'Column Picker'. This doesn't look nice and wasn't so in TB 102 as well.
And maybe it could be considered to align date column as well.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: Bug 1848834 - Add on the end aligned columns a padding when they are at the end of the row. r=aleca

Comment 2

[Alfred Peters [:infofrommozilla]]

(In reply to [e-mail] from comment #0)

Since #184604

You might be referring to Bug 1848604.

Comment 3

[[e-mail]]

(In reply to Alfred Peters from comment #2)

(In reply to [e-mail] from comment #0)

Since #184604

You might be referring to Bug 1848604.

I'm sure I am.

Comment 4

[[e-mail]]

And please consider having the column title 'Size' itself left aligned, like all other column titles.

Comment 5

[Anje]

Generally, in all subjects etc etc, it has always been accepted that text aligns left (unless written right to left) because text is appended on the right side and all numerical data is aligned to the right because numbers increase on the left side. Otherwise numbers look wrong, the HTU columns need to be aligned.
The only exception under 'numerical data' is the Date because it is written in text format and may include text eg: day as users can determine it's display format, so it is generally aligned to the left.
So 'Size' and 'Total' would be examples of right alignment.
and 'Date, From, Subject are examples of columns that should be aligned left.

Comment 6

[[e-mail]]

Basically I totally agree. However, for date I'd like to somewhat disagree. Having date right aligned would place all times (hh:mm) below the others independent from other information. Which I think is easier to follow then a left alignment where usually you'll find full dates (mm/dd/yy, hh:mm), dates by weekdays (ddd, hh:mm) and times (hh:mm) below each other. But it's not a big deal since it can easily be achieved by a CSS statement.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f41f523d9121
Add on the end aligned columns a padding when they are at the end of the row. r=aleca

Comment 8

[Richard Marti (:Paenglab)]

Comment on attachment 9349170 [details]
Bug 1848834 - Add on the end aligned columns a padding when they are at the end of the row. r=aleca

[Approval Request Comment]
Regression caused by (bug #): bug 184604
User impact if declined: when the right aligned columns are the last in thread tree then the content is shown below the column picker
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 9

[Wayne Mery (:wsmwk)]

Comment on attachment 9349170 [details]
Bug 1848834 - Add on the end aligned columns a padding when they are at the end of the row. r=aleca

[Triage Comment]
Approved for esr115

I'm going to leave the beta request flag here, but there might not be a beta before the 118 merge

Comment 10

[Rob Lemley [:rjl]]

Thunderbird 115.2.0:
https://hg.mozilla.org/releases/comm-esr115/rev/7b97f80efa86

Comment 11

[Richard Marti (:Paenglab)]

Attachment: Bug 1848834 - Add the additional scrollbar padding only with overlay scrollbars. r=aleca

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/bf8c5ad4b925
Add the additional scrollbar padding only with overlay scrollbars. r=aleca

Comment 13

[Richard Marti (:Paenglab)]

Comment on attachment 9349555 [details]
Bug 1848834 - Add the additional scrollbar padding only with overlay scrollbars. r=aleca

[Approval Request Comment]
Regression caused by (bug #): Bug 1848834
User impact if declined: on systems without overlay scrollbars too much padding
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 14

[Wayne Mery (:wsmwk)]

Comment on attachment 9349555 [details]
Bug 1848834 - Add the additional scrollbar padding only with overlay scrollbars. r=aleca

[Triage Comment]
Approved for beta (we might have other one next week)

Comment 15

[Wayne Mery (:wsmwk)]

Comment on attachment 9349555 [details]
Bug 1848834 - Add the additional scrollbar padding only with overlay scrollbars. r=aleca

[Triage Comment]
We did not take additional patches into 117.0b6 (and b5 was skipped)

Comment 16

[Rob Lemley [:rjl]]

Thunderbird 115.2.0:
https://hg.mozilla.org/releases/comm-esr115/rev/d8f80cee9885

Comment 17

[Wayne Mery (:wsmwk)]

Comment on attachment 9349555 [details]
Bug 1848834 - Add the additional scrollbar padding only with overlay scrollbars. r=aleca

[Triage Comment]
approved for esr115 (this hunk was already uplifted to 115.2.0)