1849159 - The Address bar Fakespot icon does not change its state when the user Turns off the Review quality Check from Settings

Status: VERIFIED FIXED

(Firefox :: Shopping, defect, P1)

Description

[Rares Doghi, Desktop QA]

Attachment: IconState.mp4

Found in

• Nightly 118.0a1 (2023-08-17)

Affected versions

• Nightly 118.0a1 (2023-08-17)

Affected platforms

• ALL

Preconditions:
Set the browser.shopping.experience2023.enabled - TRUE
Set the browser.shopping.experience2023.optedIn - 1
Set the toolkit.shopping.useOHTTP - TRUE

Steps to reproduce

1. Reach the Amazon.com website and search for nintendo switch.
2. Select any product in order to reach the product details page.
3. Expand the Settings card.
4. Click the Turn off Quality check.

Expected result

• The Fakespot address bar icon is displayed as disabled. (Black)

Actual result

• The Address bar icon remains disabled without any functionality.

Regression range
Not Applicable

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:rdoghi, if you think that's a regression, could you try to find a regression range using for example mozregression?

Comment 2

[Ania]

This is exacerbated by the shopping icon remaining the URL bar after the feature is turned off.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Should this be an S1 severity bug?
https://wiki.mozilla.org/BMO/UserGuide/BugFields#bug_severity

(Catastrophic) Blocks development/testing, may impact more than 25% of users, causes data loss, likely dot release driver, and no workaround available

Comment 4

[Jonathan Epstein]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #3)

Should this be an S1 severity bug?

Only affects 119

Comment 5

[Niklas Baumgardner [:niklas]]

Attachment: Bug 1849159 - Toolbar button should hide when opted out. r=#shopping-reviewers

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4ced56d93af6
Toolbar button should hide when opted out. r=shopping-reviewers,Gijs

Comment 7

[Serban Stanca [:SerbanS]]

Backed out for causing mochitests failures in browser_stale_product.js.

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/components/shopping/tests/browser/browser_stale_product.js | Got shopping-message-bar element

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/91e76d818152
Toolbar button should hide when opted out. r=shopping-reviewers,Gijs

Comment 9

[Sandor Molnar[:smolnar]]

Backed out for causing bc failures in browser/components/shopping/tests/browser/browser_shopping_urlbar.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/d27e296d063646b27f783abf7aa485f604821dbc

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | browser/components/shopping/tests/browser/browser_shopping_urlbar.js | Uncaught exception in test bound test_button_hidden_when_opted_out

Failure log -> TEST-UNEXPECTED-FAIL | browser/components/shopping/tests/browser/browser_shopping_settings.js | Uncaught exception in test bound test_settings_toggle_ad_and_multiple_tabs

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/780b5a0c48aa
Toolbar button should hide when opted out. r=shopping-reviewers,Gijs

Comment 12

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/780b5a0c48aa

Comment 13

[Peter Magyari (Desktop QA)]

Verified fixed using Nightly 119.0a1 (2023-09-08) on MacOS 11, Windows 10 and Ubuntu 20.04, the toolbar icon hides when opted out accordingly.

Comment 14

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Turns out we actually did not want to disable the urlbar button if the user opts out. So I'll be reverting this change presently.