1849368 - Mailto link does not open default app or query which app to use

Status: VERIFIED FIXED

(Firefox for Android :: App Links, defect)

Description

[Denis Müller [:Webworkr]]

User Agent: Mozilla/5.0 (Android 13; Mobile; rv:109.0) Gecko/118.0 Firefox/118.0

Steps to reproduce:

Call a mailto link.

Actual results:

Another tab opens, then nothing happens.

Expected results:

Usually, the default app is then called or the user is asked which app should be used.

Comment 1

[Denis Müller [:Webworkr]]

Samsung Galaxy A13 5G (SM-A136B)
Android 13

Comment 2

[Denis Müller [:Webworkr]]

Under Fennec, this function works as expected.

116.2.0 (build #1162000), 1c64add6ac+.
GV: 116.0.2-20230811160510
AS: 116.0

Comment 3

[Denis Müller [:Webworkr]]

It is possible that there is a connection here. Both tickets are about the default settings of default apps directly or indirectly:
Bug 1840720, Bug 1849368

Comment 4

[Lorand Janos]

Hi,
While at first I couldn't reproduce this issue on the latest Nightly (118.0a1 from 2023-08-22), using a Google Pixel 7 (Android 14),
I was able to reproduce the issue on a similar device than the one mentioned in the ticket (Samsung Galaxy Tab A7 with Android 13) on the same, latest Nightly build.

The difference was that it didn't even open another tab, it just started loading and the loading stopped shortly, doing nothing else.

I've used some examples from https://www.rapidtables.com/web/html/mailto.html.

Tested on 116 and 117 as well, and on the latest Beta 117.0b9 the issue was reproducible.

Comment 6

[Djfe]

Attachment: Screenshot

Paste and open a mailto link directly

Funny error. Maybe a symptom.

Error message untranslated (atleast in German) so far.
If the string is new, then it could lead us to the commit introducing this regression.

Release 117.0, Beta 118 and Nightly 119 are affected atleast.

Comment 7

[Djfe]

for me mailto links do nothing. the address bar flickers a loading bar. but no new tab

Comment 8

[Sören Hentzschel]

Not only mailto: links are affected, tel: links are broken as well in Firefox 117. You will be asked the first time you click on a tel: link but once you press the cancel button it never works again until you remove Firefox from the recent apps and start it again. Could be related to the mailto: issue.

Comment 9

[jackyzy823]

but once you press the cancel button it never works again until you remove Firefox from the recent apps and start it again

Bug 1847273

Paste and open a mailto link directly

Not sure i understood correctly . Are you input mailto:[e-mail] in address bar and then load it?
If so , Fenix may misinterpret it in http protocol as https://mail:[e-mail] (Basic Auth: username: mail password: xxx for site abc.def)

Comment 10

[Djfe]

Jackyzy823, you are right. And that explains the error.
Mistake on my side, this is not part of the regression. You aren't supposed to be able to paste mailto links into the address bar. The error is shown on Firefox 116.0b8 already (the newest 116 version I'm able to install in parrallel outside of release) so it's not part of the regression.

I'm using a Google Pixel 7 Pro on Android 13. (in-case this only affects some devices/Android versions)

Comment 11

[Denis Müller [:Webworkr]]

(In reply to Sören Hentzschel from comment #8)

Not only mailto: links are affected, tel: links are broken as well in Firefox 117. You will be asked the first time you click on a tel: link but once you press the cancel button it never works again until you remove Firefox from the recent apps and start it again. Could be related to the mailto: issue.

I have also observed problems with "tel links", but had not connected them with "mailto" before. I previously assumed an error in the HTML code of the respective page. I use "mailto" much more often than "tel". Due to the low usage, I have not classified it as a browser problem until now.

Would it be appropriate to change the title of this issue then?

Comment 12

[Denis Müller [:Webworkr]]

As for opening another tab, the error occurs both with and without opening another tab.

I have also observed that when downloading PDFs, for example, another tab is first opened, and the content of the PDF is then only displayed in a third tab. While not directly related to this issue, it may be helpful to the developers.

Comment 13

[Sören Hentzschel]

Would it be appropriate to change the title of this issue then?

jackyzy823 mentioned bug 1847273 (thanks for that!). I think bug 1847273 covers the tel: problem and your ticket can therefore focus on the mailto: problem. Maybe both issues have the same or a similar cause but I am not sure.

Comment 14

[Denis Müller [:Webworkr]]

(In reply to Sören Hentzschel from comment #13)

Would it be appropriate to change the title of this issue then?

jackyzy823 mentioned bug 1847273 (thanks for that!). I think bug 1847273 covers the tel: problem and your ticket can therefore focus on the mailto: problem. Maybe both issues have the same or a similar cause but I am not sure.

OK, shouldn't bug 1847273 also contain a reference to this ticket?

Comment 15

[Djfe]

does anyone know how to regression test this?
mozregression appears to support to only gve which does support neither mailto nor tel links
:zeid

Comment 16

[Zeid [:zeid]]

There is currently no support for Fenix in mozregression, however there are potential future plans to add support.

Comment 17

[Zeid [:zeid]]

:Djfe -- I released a development release (5.10.0.dev0) that has basic support for Fenix + start URL, you should be able to use it to run these tests (however, I only tested this on the CLI). You can use mozregression --app fenix --arch arm64-v8a --arg <url>. (note: you may have to change arch and be specific about good/bad date range.) Let me know if you're able to use this.

Comment 18

[Djfe]

awesome! thank you very much 😊
I'll take a look tonight

Comment 19

[Djfe]

Outcome:
8:06.81 INFO: Newest known good nightly: 2023-07-12
8:06.81 INFO: Oldest known bad nightly: 2023-07-13

Offtopic for :zeid
Not sure if this is a bug, but Mozregression 5.10.0.dev0 tells me there's a new version available: 5.9.1
There might be a bug in the code that compares versions.
Or it just compares: is my version equal to newest release version ^^

Please check the attached log, it might allow you to fix some bugs.
If it helps development, then I could rerun this as verbose:
mozregression --log-mach-level debug

Comment 20

[Djfe]

Attachment: mozregression-fenix.log

for zeid

Comment 21

[Djfe]

Also, might be helpful:
This happens, right when I select fenix in the application dropdown in the GUI

platform: Windows-10-10.0.19045-SP0
python: 3.10.11 FROZEN (64bit)
mozregression: 5.10.0.dev0
message: KeyError: None
traceback: File "mozregui\wizard.py", line 122, in _set_fetch_config
File "C:\Program Files (x86)\mozregression-gui\mozregression\fetch_configs.py", line 551, in create_config
return REGISTRY.get(name)(os, bits, processor, arch)
File "C:\Program Files (x86)\mozregression-gui\mozregression\fetch_configs.py", line 106, in init
self.set_arch(arch)
File "C:\Program Files (x86)\mozregression-gui\mozregression\fetch_configs.py", line 656, in set_arch
self.arch_regex_bits = mapping[self.arch]

Comment 22

[Djfe]

rough commit range:
https://github.com/mozilla-mobile/firefox-android/commits/main?before=430a9fd10df0c99789d22f7129c985da463b454a+656&branch=main&qualified_name=refs%2Fheads%2Fmain

I assume this bug was caused by this commit (by title)
https://github.com/mozilla-mobile/firefox-android/commit/1714d5bf9ee7b05cb01b569ae164dbdc5a4295aa
Regressed by: Bug 1835816

:royang Hi Roger, your commit from July might be the one to have broken support for mailto: and tel: links.
Please help us by taking a look :)

I've never built Firefox/Fenix before else I would've quickly tested reverting the commit before calling you here.

Comment 23

[Zeid [:zeid]]

Thanks :Djfe, the bug with fenix arch will be fixed in the release. As for the other bug with the new release notifications, that is actually a known issue and is tracked in bug 1631163.

Comment 24

[Roger Yang [:royang]]

Thanks :Djfe, I'll take a look.

Comment 25

[Djfe]

OT:
are the other errors in mozregression (see log) expected for Android 13 without root access? :zeid

Comment 26

[Roger Yang [:royang]]

Attachment: device-2023-09-19-154109.mp4

Comment 27

[Roger Yang [:royang]]

Hi : Djfe, I couldn't reproduce it. I've used the suggested site's mailto example and it works on release (117.1.0) and nightly. Please see attached video. What email client do you use as default? Thanks

Comment 28

[Sören Hentzschel]

Djfe, I couldn't reproduce it. I've used the suggested site's mailto example and it works on release (117.1.0) and nightly.

I am not Djfe, but for me, it still doesn't work in Firefox 117.1.0 on the OnePlus 10 Pro with Android 13.

Please see attached video

The video does neither work in Firefox on macOS nor on Android, so I can't see it.

What email client do you use as default?

Gmail

Comment 29

[Roger Yang [:royang]]

Attachment: device-2023-09-19-155512.webm

Comment 30

[Roger Yang [:royang]]

(In reply to Sören Hentzschel from comment #28)

The video does neither work in Firefox on macOS nor on Android, so I can't see it.

Updated. Should have checked the video since Android Studio have a video recording issue. It should work now. Does this look similar to what you see? Do you see the prompt to open the link? Thanks

Comment 31

[Sören Hentzschel]

Updated. Should have checked the video since Android Studio have a video recording issue. It should work now.

Thanks, the video works now.

Do you see the prompt to open the link?

No, there is no prompt, no matter which "open links in apps" setting I use. I can see the progress bar for the fragment of a second but otherwise nothing happens at all.

Comment 32

[Roger Yang [:royang]]

(In reply to Sören Hentzschel from comment #31)

No, there is no prompt, no matter which "open links in apps" setting I use. I can see the progress bar for the fragment of a second but otherwise nothing happens at all.

I see. I am assuming now there's a very different behaviour between Android 13 on Pixel and on some other devices.
I'll try to find a device so I can reproduce. Thanks

Comment 33

[Roger Yang [:royang]]

Update. Found a Samsung S9 (Android 10) that I can reproduce this with. I think I have a fix. Will update.

Comment 34

[Djfe]

Hi my email client is K-9 (and I can open mail address with PayPal)

Weird that this is device specific. What was the first device and Android version you tested on?
Great that you might already have a fix 👌

Comment 35

[Roger Yang [:royang]]

Yes, surprisingly this was device specific. I couldn't reproduce it on Pixel 7 (Android 13), Pixel 3 (Android 12) and emulated Pixel 4 on Android 9. I will put up a fix soon. I'm not sure if it's just Samsung devices. There could be other devices that are affected. But I can consistently reproduce it on Samsung S9 test phone that I have.

Comment 36

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1849368 - Remove data path and data authorities requirement for open links in apps (#3739)

Comment 37

[Djfe]

I was reproducing this on my Pixel 7 Pro (256gb) on Android 13
I almost can't imagine it being that device specific 😮.

Looking forward to testing the fix to see whether it also fixes it for my device 🤔

Comment 38

[Djfe]

Thank you Roger, I was able to verify, that your fix works :)

Hopefully the change can be backported to the release after merging

Comment 39

[Roger Yang [:royang]]

(In reply to Djfe from comment #38)

Thank you Roger, I was able to verify, that your fix works :)

Hopefully the change can be backported to the release after merging

Thanks for confirming. Sure, once it lands in Nightly I'll let it soak for a few days. If nothing goes wrong I'll lift to beta and release

Comment 41

[BMO Github Automation]

Authored by https://github.com/rocketsroger
https://github.com/mozilla-mobile/firefox-android/commit/0f66757c01b3ee51064164c8a58a2856d27ea8b7
[main] Bug 1849368 - Remove data path and data authorities requirement for open links in apps

Comment 42

[Roger Yang [:royang]]

To test, please use a Samsung device, go to a site where there's a mailto link (example: https://www.w3docs.com/snippets/html/how-to-create-mailto-links.html) tap on the send mail link to confirm that it redirects to the default mail app.

Comment 43

[BugBot [:suhaib / :marco/ :calixte]]

Since nightly and release are affected, beta will likely be affected too.
For more information, please visit BugBot documentation.

Comment 44

[Denis Müller [:Webworkr]]

(In reply to Roger Yang [:royang] from comment #42)

To test, please use a Samsung device, go to a site where there's a mailto link (example: https://www.w3docs.com/snippets/html/how-to-create-mailto-links.html) tap on the send mail link to confirm that it redirects to the default mail app.

Works for me with all installed mail applications (plus PayPal app).

Tested environment:

• Samsung Galaxy A13 5G (SM-A136B)
• Android 13
• 120.0a1 (Build #2015976737), 39583a5636+
  GV: 120.0a1-20230927212433
  AS: 120.20230927050226

Thank you

Comment 45

[Denis Müller [:Webworkr]]

(In reply to Denis Müller [:Webworkr] from comment #44)

(In reply to Roger Yang [:royang] from comment #42)

To test, please use a Samsung device, go to a site where there's a mailto link (example: https://www.w3docs.com/snippets/html/how-to-create-mailto-links.html) tap on the send mail link to confirm that it redirects to the default mail app.

Works for me with all installed mail applications (plus PayPal app).

Tested environment:

• Samsung Galaxy A13 5G (SM-A136B)
• Android 13
• 120.0a1 (Build #2015976737), 39583a5636+
  GV: 120.0a1-20230927212433
  AS: 120.20230927050226

Thank you

Addendum:
Used browser: Nightly

Comment 46

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:royang, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox119 to wontfix.

For more information, please visit BugBot documentation.

Comment 47

[Delia Pop (Android QA)]

Verified fixed in the latest Nightly 120.0a1 from 09/28 with Samsung Galaxy A53 5G (Android 13) and Samsung Galaxy Note10 (Android 12). The user is redirected to the default mail app.

Comment 48

[Roger Yang [:royang]]

(In reply to Denis Müller [:Webworkr] from comment #44)

Works for me with all installed mail applications (plus PayPal app).

Thanks!

Comment 49

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1849368 - Remove data path and data authorities requirement for open links in apps (backport #3739) (#3853)

Comment 50

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1849368 - Remove data path and data authorities requirement for open links in apps (backport #3739) (#3854)

Comment 51

[Roger Yang [:royang]]

Comment on attachment 9354402 [details] [review]
[mozilla-mobile/firefox-android] Bug 1849368 - Remove data path and data authorities requirement for open links in apps (#3739)

Beta/Release Uplift Approval Request

• User impact if declined: mailto links will not work properly on Samsung or some non-pixel devices.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): mailto links will not work properly on some devices
• String changes made/needed: N/A
• Is Android affected?: Yes

Comment 52

[BMO Github Automation]

Authored by https://github.com/rocketsroger
https://github.com/mozilla-mobile/firefox-android/commit/58d65ec5a4dd5dc7ff3b894d88bcd672a10caab1
[releases_v119] Bug 1849368 - Remove data path and data authorities requirement for open links in apps

Comment 53

[Dianna Smith [:diannaS]]

Comment on attachment 9355733 [details] [review]
[mozilla-mobile/firefox-android] Bug 1849368 - Remove data path and data authorities requirement for open links in apps (backport #3739) (#3853)

Approved for Mobile 119.0b3

Comment 54

[Dianna Smith [:diannaS]]

Comment on attachment 9354402 [details] [review]
[mozilla-mobile/firefox-android] Bug 1849368 - Remove data path and data authorities requirement for open links in apps (#3739)

correcting the flags to correspond to each release target

Comment 55

[Delia Pop (Android QA)]

Verified fixed on Beta 119.0b3 with Samsung Galaxy A53 5G (Android 13) and Samsung Galaxy Note10 (Android 12). The user is redirected to the default mail app.

Comment 56

[Pascal Chevrel:pascalc]

Comment on attachment 9355735 [details] [review]
[mozilla-mobile/firefox-android] Bug 1849368 - Remove data path and data authorities requirement for open links in apps (backport #3739) (#3854)

One line fix, verified in beta, approved for our next 118 dot release, thanks.

Comment 57

[BMO Github Automation]

Authored by https://github.com/rocketsroger
https://github.com/mozilla-mobile/firefox-android/commit/7bd75eaf20644d5dd7717dda0f9610bf2924a651
[releases_v118] Bug 1849368 - Remove data path and data authorities requirement for open links in apps

Comment 58

[Mira Lobontiu (Android QA)]

Verified on RC 118.1.1 build 1 with Lenovo tablet M10 (Android 10), and Oppo Find N2 Flip (Android 13).

Comment 59

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Revert "Bug 1849368 - Remove data path and data authorities requirement for open links in apps" (#4001)

Comment 60

[BMO Github Automation]

Authored by https://github.com/rocketsroger
https://github.com/mozilla-mobile/firefox-android/commit/6a1bcc41964cb77686c70a0e9155bbfdc47296ad
[main] Revert "Bug 1849368 - Remove data path and data authorities requirement for open links in apps"

Comment 61

[Mira Lobontiu (Android QA)]

Verified on the latest Fenix Nightly 120.0a1 build from 10/13 with the following devices:

• Samsung Galaxy Note 8 (Android 9), and
• Xiaomi Mi8 Lite (Android 10).

Tested the following pages:

• https://www.rapidtables.com/web/html/mailto.html
• https://daleharvey.github.io/testapp/
• https://www.w3docs.com/snippets/html/how-to-create-mailto-links.html