1849374 - "Open in conversation" now displays an unthreaded list of messages

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect)

Description

[enzomas]

Steps to reproduce:

Select a message and choose "open in conversation"

Actual results:

All the message of the conversation are displayed in a new tab, according to a given order, but they are not displayed as a thread (hiearchical tree). To do so I have to manually activate theaded view, and then unfold the thread to see all the messages. I have to repeat these operations each time I use "open in conversation" : the threaded view mode is not saved.

Expected results:

In previous versions of TB, the conversation view opens a list of messages that are displayed as a thread.

Comment 1

[Anje]

Testing Windows 10 OS using beta 117.0b4 and 102.14.0

• In Message List/Thread Pane using Sort by > Threaded
• Select email which has subthreads
• right click on email and select 'Open in Conversation'

***Note: ***

• in 117.0b4 menu option 'Open in Conversation' is available regardless of whether thread is collapsed or expanded.
• in 102.14.0 menu option 'Open in Conversation' is ONLY available if thread is expanded.

There seems to be a change in this menu option which I find as really good as you should be able to select a collapsed thread and ask to open in conversion. I see this part as an improvement.

• new tab appears containing all the relevant emails to that conversation.
• in 117.0b4 emails appear in 'unthreaded' format by default and need to click on the 'Threads' column icon to switch on 'threaded' view.
• in 102.14.0 emails appear in threaded format by default.

The menu option 'Open in Conversation' implies this would be a threaded view as it is following reponses including input by various people on a topic and/or replies.

Expected
Thread view

Actual
Unthreaded view

I can reproduce this in beta 117.0b4

Comment 3

[Mark Banner (:standard8)]

I can confirm this, I think it is a regression from bug 1789774.

The old Gloda Tab view would force the threaded state when creating the view.

I don't see an easy way of doing that with the new tab-setup. Geoff, any ideas? (I have a similar issue for Conversations as well).

Comment 4

[Geoff Lankow (:darktrojan)]

Hmm. We seem to be ignoring the default for this (default is 1). If we don't ignore it, this bug goes away. I'm wondering if it's really that simple.

There's a line of code which attempts to set the flags but the effect is wiped out by the next line, and the same when it comes to opening ordinary folders. Both of these lines are effectively useless.

Comment 5

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1849374 - Stop ignoring value of mailnews.default_view_flags. r=#thunderbird-reviewers

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/7a8fe1d65844
Stop ignoring value of mailnews.default_view_flags. r=aleca

Comment 7

[Geoff Lankow (:darktrojan)]

Comment on attachment 9353834 [details]
Bug 1849374 - Stop ignoring value of mailnews.default_view_flags. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): never worked but the default changed in bug 1764842
User impact if declined: conversation list not threaded
Testing completed (on c-c, etc.): in 119
Risk to taking this patch (and alternatives if risky): low

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 9353834 [details]
Bug 1849374 - Stop ignoring value of mailnews.default_view_flags. r=#thunderbird-reviewers

[Triage Comment]
Approved for esr115

Comment 9

[Rob Lemley [:rjl]]

Thunderbird 115.3.2:
https://hg.mozilla.org/releases/comm-esr115/rev/82486d9909de

Comment 10

[enzomas]

Thank you, the patch restored threaded view in the conversation view.

However, there remains a defect which is that the thread is systematically collapsed, whereas in previous versions <115, the thread was systematically expanded: so each time you use “open in conversation” you must press * key to get a full view of the thread.

Comment 11

[Mark Banner (:standard8)]

(In reply to enzomas from comment #10)

Thank you, the patch restored threaded view in the conversation view.

However, there remains a defect which is that the thread is systematically collapsed, whereas in previous versions <115, the thread was systematically expanded: so each time you use “open in conversation” you must press * key to get a full view of the thread.

Since this has been landed and fixed, please can you file a new bug for that, so that it can be tracked. Otherwise the comment may get lost.