1789774 - Remove the old 3-pane code

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, task)

Description

[Geoff Lankow (:darktrojan)]

This is where I'm going to remove thousands of lines of code added over the years.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1789774 - Remove the folder tree view and context menu. r=aleca

Comment 2

[Geoff Lankow (:darktrojan)]

https://hg.mozilla.org/projects/ash/rev/04a3e0133c3d6a8c4e670c6a8e9526b3600c33e7

Comment 3

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1789774 - Stop using the `glodaList` tab type. r=aleca

Comment 4

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1789774 - Remove the old mail tab types. r=aleca

The new tabs will remain newMailTabType for now until to avoid confusion if there's anything remaining pointing at the old type.

Depends on D157278

Comment 5

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1789774 - Remove the `mail.useNewMailTabs` pref. r=aleca

Depends on D157279

Comment 6

[Geoff Lankow (:darktrojan)]

https://hg.mozilla.org/projects/ash/rev/e3918987249c1a11b5b35e13cd3d4f1e2473311a
https://hg.mozilla.org/projects/ash/rev/440d8eabee15054ff9eae991c4de69961208f21c
https://hg.mozilla.org/projects/ash/rev/9823ddec9e2c42886086e2d182c89dd47e472f4a

Comment 7

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1789774 - Convert the standalone message window to use about:message. r=aleca

Comment 8

[Geoff Lankow (:darktrojan)]

https://hg.mozilla.org/projects/ash/rev/b668c32b3f40e1c192dd3b56bdba7ca955b09b45

Comment 9

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1789774 - Remove the old message pane elements and associated functions. r=aleca

Comment 10

[Geoff Lankow (:darktrojan)]

https://hg.mozilla.org/projects/ash/rev/5d30f70cb1f6bf9f82ce0938ce64307c7216fb28

Comment 11

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1789774 - Remove message items from main window context menu. r=aleca

This menu isn't used in message display panes or the thread pane any more. It should probably get a new name but this'll do for now.

Comment 12

[Geoff Lankow (:darktrojan)]

https://hg.mozilla.org/projects/ash/rev/20cb7da0af5f41b2266ad6896610babba5985fc6

Comment 13

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1789774 - Move all message tagging code inside about:3pane/about:message. r=aleca

Comment 14

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1789774 - Remove navigation code from the main windows. r=aleca

Depends on D158389

Comment 15

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1789774 - Move conversation opening code inside about:3pane/about:message. r=aleca

Depends on D158390

Comment 16

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1789774 - Remove commands from the main windows that can be handled in about:3pane/about:message. r=aleca

Depends on D158391

Comment 17

[Geoff Lankow (:darktrojan)]

https://hg.mozilla.org/projects/ash/rev/2165ea486dd27995d79470bffd963085a1516520
https://hg.mozilla.org/projects/ash/rev/f479dadee34702ed68a05295744aee817c666e62
https://hg.mozilla.org/projects/ash/rev/c05a8953c7487a12ba7971541e5f7a21f09431f0
https://hg.mozilla.org/projects/ash/rev/38b68a4a2c055fc3289b830eb24f878b8dd6bcdd

Comment 18

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1789774 - Move message header elements and functions into the about:message window. r=aleca

These popups and functions are for the message header only. Moving them all at once into the message header files, whether or not it makes sense to keep them.

Comment 19

[Geoff Lankow (:darktrojan)]

https://hg.mozilla.org/projects/ash/rev/ef7a1e7681cf622cf7017cd96f483429a13d0f61

Comment 20

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1789774 - Move more commands into about:3pane/about:message. r=aleca

Comment 21

[Geoff Lankow (:darktrojan)]

https://hg.mozilla.org/projects/ash/rev/3a6e8ceb0db2c17bcc365b87c6f04569e2f1081d
https://hg.mozilla.org/projects/ash/rev/703a56ddb03f2bbd9be538ac761ddb2c8e237ca1

Comment 22

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1789774 - Remove messageDisplay.js and confine folderDisplay.js to the search dialog. r=aleca

This largely destroys the old UI by removing the gFolderDisplay and gMessageDisplay objects from everywhere except the search dialog and the shims in about:message.
A lot of code still expects these variables to exist so the following patch will deal with it.

Comment 23

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1789774 - Remove lots of dead front-end code. r=aleca

This fixes a lot of linter errors from the previous patch by removing the code in question, most of which was dead anyway.

Depends on D159347

Comment 24

[Geoff Lankow (:darktrojan)]

https://hg.mozilla.org/projects/ash/rev/7ad0631d10830f02972932ff3957c88a3a8f3e5f
https://hg.mozilla.org/projects/ash/rev/cdd21294a715aeee4e12c4ce66c7b743e4e46d95

Comment 25

[Geoff Lankow (:darktrojan)]

I'm calling this one done.

Comment 26

[Geoff Lankow (:darktrojan)]

https://hg.mozilla.org/comm-central/rev/cdd21294a715aeee4e12c4ce66c7b743e4e46d95
https://hg.mozilla.org/comm-central/rev/7ad0631d10830f02972932ff3957c88a3a8f3e5f
https://hg.mozilla.org/comm-central/rev/703a56ddb03f2bbd9be538ac761ddb2c8e237ca1
https://hg.mozilla.org/comm-central/rev/3a6e8ceb0db2c17bcc365b87c6f04569e2f1081d
https://hg.mozilla.org/comm-central/rev/ef7a1e7681cf622cf7017cd96f483429a13d0f61
https://hg.mozilla.org/comm-central/rev/38b68a4a2c055fc3289b830eb24f878b8dd6bcdd
https://hg.mozilla.org/comm-central/rev/c05a8953c7487a12ba7971541e5f7a21f09431f0
https://hg.mozilla.org/comm-central/rev/f479dadee34702ed68a05295744aee817c666e62
https://hg.mozilla.org/comm-central/rev/2165ea486dd27995d79470bffd963085a1516520
https://hg.mozilla.org/comm-central/rev/20cb7da0af5f41b2266ad6896610babba5985fc6
https://hg.mozilla.org/comm-central/rev/5d30f70cb1f6bf9f82ce0938ce64307c7216fb28
https://hg.mozilla.org/comm-central/rev/b668c32b3f40e1c192dd3b56bdba7ca955b09b45
https://hg.mozilla.org/comm-central/rev/9823ddec9e2c42886086e2d182c89dd47e472f4a
https://hg.mozilla.org/comm-central/rev/440d8eabee15054ff9eae991c4de69961208f21c
https://hg.mozilla.org/comm-central/rev/e3918987249c1a11b5b35e13cd3d4f1e2473311a
https://hg.mozilla.org/comm-central/rev/04a3e0133c3d6a8c4e670c6a8e9526b3600c33e7