Intermittent FOGFixture.TestCppTimingDistWorks | Expected: (data.sum) > ((uint64_t)(15 * NANOS_IN_MILLIS) - EPSILON), actual: 10734000 vs 14800000 @ /builds/worker/checkouts/gecko/toolkit/components/glean/tests/gtest/TestFog.cpp:264
Categories
(Toolkit :: Telemetry, defect, P5)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox-esr115 | --- | wontfix |
People
(Reporter: intermittent-bug-filer, Unassigned)
References
Details
(Keywords: intermittent-failure)
Filed by: ncsoregi [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=426514312&repo=mozilla-esr115
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/cpYQ1Na5QgezNLhNTM47gQ/runs/0/artifacts/public/logs/live_backing.log
[task 2023-08-18T21:07:58.880Z] 21:07:58 INFO - TEST-START | FOGFixture.TestCppTimingDistWorks
[task 2023-08-18T21:07:58.911Z] 21:07:58 WARNING - TEST-UNEXPECTED-FAIL | FOGFixture.TestCppTimingDistWorks | Expected: (data.sum) > ((uint64_t)(15 * NANOS_IN_MILLIS) - EPSILON), actual: 10734000 vs 14800000 @ /builds/worker/checkouts/gecko/toolkit/components/glean/tests/gtest/TestFog.cpp:264
[task 2023-08-18T21:07:58.911Z] 21:07:58 WARNING - TEST-UNEXPECTED-FAIL | FOGFixture.TestCppTimingDistWorks | test completed (time: 20ms)
| Comment hidden (Intermittent Failures Robot) |
Comment 2•2 years ago
|
||
https://wiki.mozilla.org/Bug_Triage#Intermittent_Test_Failure_Cleanup
For more information, please visit BugBot documentation.
| Reporter | ||
Comment 3•2 years ago
|
||
| treeherder | ||
New failure instance: https://treeherder.mozilla.org/logviewer?job_id=428785674&repo=mozilla-esr115
| Comment hidden (Intermittent Failures Robot) |
Comment 5•2 years ago
|
||
https://wiki.mozilla.org/Bug_Triage#Intermittent_Test_Failure_Cleanup
For more information, please visit BugBot documentation.
Comment 6•2 years ago
|
||
As you can see from the See Also list, timing tests are tough. The most complete exploration of this particular failing is in https://bugzilla.mozilla.org/show_bug.cgi?id=1813167#c1:
The 15 * NANOS_IN_MILLIS is the assumed, reasonable sum of one timing sample that slept for two 5ms intervals plus one timing sample that slept for one 5ms interval.
HOWEVER, things are rarely (see the bugs in the See Also list for just how rare) that reasonable. Those 5ms intervals are only "roughly" 5ms long, and if each of them is shaved juuuuust enough, we can find ourselves at a sum that is 15ms - (3 * SHAVE). This is why we put in EPSILON: we hope that EPSILON > (3 * SHAVE) and simultaneously keep it as small as possible.
Alas. An EPSILON of 0.04ms is apparently not always enough. We need one of at least 0.1867ms.
(( 1.3% seems like an awful lot for a timer to be off... but remember, this is three compounding errors, so it averages to 0.41%. Still not great, but. ))
(( Also, we straight up use an EPSILON of 2ms in the JS versions of this test (most of that's due to rounding, but not all of it) ))
A decent fix for this would be to up EPSILON to 200000 or (uint64_t)(0.2 * NANOS_IN_MILLIS)
If this comes back, we may need to re-examine whether we're correctly accounting for the errors in the three measurements or whether we're missing something.
| Reporter | ||
Comment 7•2 years ago
|
||
| treeherder | ||
New failure instance: https://treeherder.mozilla.org/logviewer?job_id=432435691&repo=mozilla-esr115
| Comment hidden (Intermittent Failures Robot) |
Comment 9•2 years ago
|
||
https://wiki.mozilla.org/Bug_Triage#Intermittent_Test_Failure_Cleanup
For more information, please visit BugBot documentation.
| Reporter | ||
Comment 10•2 years ago
|
||
| treeherder | ||
New failure instance: https://treeherder.mozilla.org/logviewer?job_id=437858631&repo=mozilla-esr115
| Comment hidden (Intermittent Failures Robot) |
Comment 12•2 years ago
|
||
https://wiki.mozilla.org/Bug_Triage#Intermittent_Test_Failure_Cleanup
For more information, please visit BugBot documentation.
| Reporter | ||
Comment 13•2 years ago
|
||
| treeherder | ||
New failure instance: https://treeherder.mozilla.org/logviewer?job_id=442336395&repo=mozilla-esr115
| Comment hidden (Intermittent Failures Robot) |
Comment 15•2 years ago
|
||
https://wiki.mozilla.org/Bug_Triage#Intermittent_Test_Failure_Cleanup
For more information, please visit BugBot documentation.
| Reporter | ||
Comment 16•2 years ago
|
||
| treeherder | ||
New failure instance: https://treeherder.mozilla.org/logviewer?job_id=446723247&repo=mozilla-esr115
| Comment hidden (Intermittent Failures Robot) |
Comment 18•2 years ago
|
||
https://wiki.mozilla.org/Bug_Triage#Intermittent_Test_Failure_Cleanup
For more information, please visit BugBot documentation.
| Reporter | ||
Comment 19•1 year ago
|
||
| treeherder | ||
New failure instance: https://treeherder.mozilla.org/logviewer?job_id=487284362&repo=mozilla-esr115
| Comment hidden (Intermittent Failures Robot) |
Comment 21•1 year ago
|
||
https://wiki.mozilla.org/Bug_Triage#Intermittent_Test_Failure_Cleanup
For more information, please visit BugBot documentation.
| Reporter | ||
Comment 22•1 year ago
|
||
| treeherder | ||
New failure instance: https://treeherder.mozilla.org/logviewer?job_id=493703468&repo=mozilla-esr115
| Comment hidden (Intermittent Failures Robot) |
Comment 24•1 year ago
|
||
https://wiki.mozilla.org/Bug_Triage#Intermittent_Test_Failure_Cleanup
For more information, please visit BugBot documentation.
| Comment hidden (Intermittent Failures Robot) |
| Comment hidden (Intermittent Failures Robot) |
| Reporter | ||
Comment 27•1 year ago
|
||
| treeherder | ||
New failure instance: https://treeherder.mozilla.org/logviewer?job_id=508626774&repo=mozilla-esr115
| Comment hidden (Intermittent Failures Robot) |
Comment 29•1 year ago
|
||
https://wiki.mozilla.org/Bug_Triage#Intermittent_Test_Failure_Cleanup
For more information, please visit BugBot documentation.
| Comment hidden (Intermittent Failures Robot) |
Updated•1 year ago
|
| Comment hidden (Intermittent Failures Robot) |
| Comment hidden (Intermittent Failures Robot) |
Description
•