1850266 - When toggling the Quick Filter button off and on, persisted settings should be remembered

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect, P1)

Description

[Elizabeth Mitchell]

When the Quick Filter bar is turned off, the sticky value is not retained (keep filters applied when switching folders). Additionally, top-level filters in bug 1849249 are also not remembered. These settings should be remembered.

Comment 1

[Elizabeth Mitchell]

Attachment: Bug 1850266 - Remember persisted filters when toggling Quick Filter. r=#thunderbird-front-end-reviewers

• Remember persisted settings when quick filter is toggled off/on.

Depends on D186888

Comment 2

[klk745]

Will this land in the next point release?
It's a pretty annoying regression.

Comment 3

[Elizabeth Mitchell]

(In reply to klk745 from comment #2)

Will this land in the next point release?
It's a pretty annoying regression.

No, it will not land in the next point release, but I will be pushing out a patch for this this week and then we will see when it gets uplifted.

---

Priority has been raised on this as this is an accessibility issue. Keyboard navigation is severely hindered/cumbersome when Quick Filter is open. However, when Quick Filter is closed, settings are lost.

Comment 4

[Phabricator Automation]

Comment on attachment 9351830 [details]
Bug 1850266 - Remember persisted filters when toggling Quick Filter. r=#thunderbird-front-end-reviewers

Revision D187567 was moved to bug 1850265. Setting attachment 9351830 [details] to obsolete.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/cbd39e8f53fa
Remember persisted filters when toggling Quick Filter. r=aleca, sol

Comment 6

[Elizabeth Mitchell]

Comment on attachment 9351830 [details]
Bug 1850266 - Remember persisted filters when toggling Quick Filter. r=#thunderbird-front-end-reviewers

[Approval Request Comment]
Regression caused by (bug #): Changes between 102 and 115
User impact if declined: Significant. Settings that should be persisted removed when turning Quick Filter on and off. This fixes this. Additionally, this makes navigating the message list more accessible with keyboard navigation because the user can close the Quick Filter when it is not needed.
Testing completed (on c-c, etc.): Yes, try runs and this has been on c-c.
Risk to taking this patch (and alternatives if risky): Low risk.

For comm-beta, the 123 daily to 123 beta change is coming soon, so this should be automatically uplifted into the beta during that change.

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9351830 [details]
Bug 1850266 - Remember persisted filters when toggling Quick Filter. r=#thunderbird-front-end-reviewers

This is on beta since the merge.

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 9351830 [details]
Bug 1850266 - Remember persisted filters when toggling Quick Filter. r=#thunderbird-front-end-reviewers

[Triage Comment]
Approved for esr115

Comment 9

[Rob Lemley [:rjl]]

Thunderbird 115.8.0:
https://hg.mozilla.org/releases/comm-esr115/rev/d9f681318e57