1849249 - Quick Filter: Persist top-level settings on restart

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect)

Description

[Elizabeth Mitchell]

This is to remember the top-level settings that the user has selected in Quick Filter.

These include:

• Unread
• Starred
• Contacts/in address book
• Attachments

Tags will be tackled in a separate issue.

This work is needed for Bug #1846881.

---

+++ This bug was initially created as a clone of Bug #1846881, which is a clone of Bug #1846880, which is a clone of Bug #1833257 +++

Description for Bug #1846881 is included below for context.

Description

On application restart, the user's selection for the top-level buttons in Quick Filter settings should be remembered.

These buttons include:

• Unread
• Starred
• Contacts/in address book
• Tags
• Attachments

102

• Current: On restart, user selected button state is retained.
• Desired change: Keep current functionality.

115

• Current: On restart, button state is reset to not enabled
• Desired change: On restart, remember the user’s selection from earlier and set the button to that state

This returns functionality in 115 to what is the current functionality in 102.

Comment 1

[Elizabeth Mitchell]

Attachment: WIP: Bug 1849249 - Save quick filter settings in XULSTORE.

Depends on D186505

Comment 2

[Yves Goergen [:ygoe]]

Does this include the sticky state of the quick filter? It's not mentioned explicitly. That's the only one I care about as my bug was marked as duplicate of this one. I just want the sticky state to persist restarts, don't care about the others.

Comment 3

[Elizabeth Mitchell]

(In reply to Yves Goergen from comment #2)

Does this include the sticky state of the quick filter? It's not mentioned explicitly. That's the only one I care about as my bug was marked as duplicate of this one. I just want the sticky state to persist restarts, don't care about the others.

Yes, this is addressed in bug 1846880, which is part of the larger meta bug 1833257.

Comment 5

[Elizabeth Mitchell]

Attachment: Bug 1849249 - Persist top-level Quick Filter settings. r=freaktechnik

• Remember user-select top-level settings.
• Display these settings when QFB is set to enabled and sticky.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/27c9bcf2149b
Persist top-level Quick Filter settings. r=thunderbird-front-end-reviewers,freaktechnik

Comment 7

[Elizabeth Mitchell]

Comment on attachment 9350363 [details]
Bug 1849249 - Persist top-level Quick Filter settings. r=freaktechnik

[Approval Request Comment]
Regression caused by (bug #): Changes from 102 to 115
User impact if declined: Many users want the ability to persist quick filter settings on reload as they could do in 102.
Testing completed (on c-c, etc.): Tested locally, try run, and in c-c
Risk to taking this patch (and alternatives if risky): Low

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 9350363 [details]
Bug 1849249 - Persist top-level Quick Filter settings. r=freaktechnik

[Triage Comment]
Approved for beta

Comment 9

[Daniel Darnell [:dandarnell]]

Thunderbird 118.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/acf1424530b8

Comment 10

[Wayne Mery (:wsmwk)]

Comment on attachment 9350363 [details]
Bug 1849249 - Persist top-level Quick Filter settings. r=freaktechnik

[Triage Comment]
Approved for esr115

Comment 11

[Daniel Darnell [:dandarnell]]

Thunderbird 115.2.3:
https://hg.mozilla.org/releases/comm-esr115/rev/afc9977d9cfd