1861027 - Dynamically adding and removing disabled attribute on fieldset tag does not work as expected

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[fabian]

Attachment: ff_119_bug_demo.html

Steps to reproduce:

1. Create file test.html with content:
   <div style=“margin: 10px”><form><fieldset disabled><input/></fieldset></form></div>
2. Open in Firefox 119 with file://path/test.html
3. Input is disabled
4. Remove disabled attribute in dev tools

UA string of tested browser:
"Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:109.0) Gecko/20100101 Firefox/119.0"

Actual results:

After removing the disabled attribute (either by dev tools or by javascript) from the fieldset, the input element is visually enabled and focusable, but takes no input.

Expected results:

After removing the disabled attribute (either by dev tools or by javascript) from the fieldset, the input element should take input.

Comment 1

[Alice0775 White]

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=c3cb8e669cc2fbfeadba2eed88bbef838cd8a3ad&tochange=2db6638a3d8a17c7770a04473a79e7dd3f1fcc74

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:emilio, since you are the author of the regressor, bug 1850293, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1861027 - Make nsTextControlFrame -> TextControlElement casts less verbose. r=masayuki

No behavior change.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1861027 - Handle editor readonly mask update based on element state instead of attributes. r=masayuki

An element can be disabled even if it doesn't have the disabled
attribute.

Depends on D191946

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d72f1ede3640
Make nsTextControlFrame -> TextControlElement casts less verbose. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/2c7a49ec58f0
Handle editor readonly mask update based on element state instead of attributes. r=masayuki

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/42803 for changes under testing/web-platform/tests

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/d72f1ede3640
https://hg.mozilla.org/mozilla-central/rev/2c7a49ec58f0

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox120 to wontfix.

For more information, please visit BugBot documentation.

Comment 10

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1861027 - Make nsTextControlFrame -> TextControlElement casts less verbose. r=masayuki

No behavior change.

Original Revision: https://phabricator.services.mozilla.com/D191946

Comment 11

[Phabricator Automation]

Uplift Approval Request

• Steps to reproduce for manual QE testing: comment 0
• User impact if declined: Comment 0
• Code covered by automated testing: yes
• String changes made/needed: none
• Is Android affected?: yes
• Risk associated with taking this patch: low
• Explanation of risk level: Trivial-ish change + clean-up
• Needs manual QE test: yes
• Fix verified in Nightly: yes

Comment 12

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1861027 - Make nsTextControlFrame -> TextControlElement casts less verbose. r=masayuki

No behavior change.

Original Revision: https://phabricator.services.mozilla.com/D191946

Comment 13

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1861027 - Handle editor readonly mask update based on element state instead of attributes. r=masayuki

An element can be disabled even if it doesn't have the disabled
attribute.

Original Revision: https://phabricator.services.mozilla.com/D191947

Comment 14

[Phabricator Automation]

Uplift Approval Request

• Fix verified in Nightly: yes
• Needs manual QE test: yes
• Explanation of risk level: Change is rather simple.
• Risk associated with taking this patch: low
• Is Android affected?: yes
• String changes made/needed: none
• Code covered by automated testing: yes
• User impact if declined: comment 0
• Steps to reproduce for manual QE testing: comment 0

Comment 15

[Dianna Smith [:diannaS]]

Comment on attachment 9360974 [details]
Bug 1861027 - Make nsTextControlFrame -> TextControlElement casts less verbose. r=masayuki

Approved for 120.0b5

Comment 16

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/d01ded691990
https://hg.mozilla.org/releases/mozilla-beta/rev/7be1294f3227

Comment 17

[Peter Magyari (Desktop QA)]

I have reproduced the issue using Firefox 119 (20231019122658) and verified the fix using Nightly 121.0a1 (20231030164930).
I'll also verify it on Beta 5 once it is out.

Comment 18

[Donal Meehan [:dmeehan]]

:emilio what's the severity on this?
Is this safe to get a release uplift request for inclusion in next week's dot release?

Comment 19

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1861027 - Make nsTextControlFrame -> TextControlElement casts less verbose. r=masayuki

No behavior change.

Original Revision: https://phabricator.services.mozilla.com/D191946

Comment 20

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1861027 - Handle editor readonly mask update based on element state instead of attributes. r=masayuki

An element can be disabled even if it doesn't have the disabled
attribute.

Original Revision: https://phabricator.services.mozilla.com/D191947

Comment 21

[Phabricator Automation]

Uplift Approval Request

• User impact if declined: comment 0
• Code covered by automated testing: yes
• String changes made/needed: none
• Is Android affected?: yes
• Steps to reproduce for manual QE testing: comment 0
• Needs manual QE test: yes
• Fix verified in Nightly: yes
• Risk associated with taking this patch: low
• Explanation of risk level: While the first patch is a bigger refactoring it's fairly low risk. Second patch is quite minimal.

Comment 22

[Peter Magyari (Desktop QA)]

Verified fixed on Beta 120.0b5 (20231030180017).

Comment 23

[Donal Meehan [:dmeehan]]

Comment on attachment 9361187 [details]
Bug 1861027 - Handle editor readonly mask update based on element state instead of attributes. r=masayuki

Approved for 119.0.1

Comment 24

[Donal Meehan [:dmeehan]]

Comment on attachment 9361186 [details]
Bug 1861027 - Make nsTextControlFrame -> TextControlElement casts less verbose. r=masayuki

Approved for 119.0.1

Comment 25

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/d2b3a8c765fa
https://hg.mozilla.org/releases/mozilla-release/rev/0422d33a82c4

Comment 27

[Peter Magyari (Desktop QA)]

Verified fixed on Firefox 119.0.1 (20231103170431).