1850334 - Search tip text is not displayed when the browser has minimum width

Status: RESOLVED DUPLICATE of bug 1831510

(Firefox :: Address Bar, defect, P3)

Description

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: address_bar.gif

Found in

• 118.0a1 (2023-08-27)

Affected versions

• 118.0a1 (2023-08-27)
• 117.0
• 115.2.0esr

Tested platforms

• Affected platforms: Ubuntu 20, Windows 10x64, macOS 13
• Unaffected platforms: none

Preconditions

• browser.urlbar.searchTips.test.ignoreShowLimits: true

Steps to reproduce

1. Set the browser to minimum width.
2. Open a new tab.

Expected result

• Search tip text is displayed.

Actual result

• Search tip text is not displayed.

Regression range

• Last good revision: fc54299fdf1d173ee2fb89bb94a358061faebaae
  First bad revision: 70be20d80c2fbfc53b3d65c302ef190a03fa56b1
  Pushlog:
  https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=fc54299fdf1d173ee2fb89bb94a358061faebaae&tochange=70be20d80c2fbfc53b3d65c302ef190a03fa56b1
  Unfortunately, I don’t know for sure if bug 1827031 is the regressor.

Additional notes

• Attached a screen recording.
• Feel free to change the component as well if needed. Thank you!

Comment 1

[BugBot [:suhaib / :marco]]

:atrif, could you try to find a regression range using for example mozregression?

Comment 2

[BugBot [:suhaib / :marco]]

:emilio, since you are the author of the regressor, bug 1827031, could you take a look?

For more information, please visit BugBot documentation.

Comment 3

[Emilio Cobos Álvarez [:emilio]]

What was the behavior before my patch? Before my patch the urlbar would overflow which seems wrong? Also it was a very short-lived bug, so it probably went back further.

Comment 4

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: image.png

Hello Emilio! You are correct! Before this patch, the search tip text is displayed but the extensions button from the toolbar overlaps the App Menu when the browser has minimum width.

It seems that this started as follows:

1. Bug 1803873 was the first to hide the search tip when the browser is minimum width.
2. Bug 1823791 fixes the search tip but the extensions button overlaps the App Menu.
3. And then bug 1827031 hides the search tip and the extensions button no longer overlaps the App Menu.

I am attaching a screenshot for better understanding. If more information is needed please let me know.