1850429 - Fix test_iframe_srcdoc_to_remote.html test with isolateNothing and isolateHighValue strategies

Status: RESOLVED FIXED

(GeckoView Graveyard :: Sandboxing, task, P1)

Description

[[:owlish] 🦉 PST]

STR:

• Run docshell/test/mochitest/test_iframe_srcdoc_to_remote.html on any Android Fission build with isolateNothing or isolateHighValue strategy (set fission.webContentIsolationStrategy to 0 or 2 respectively).
• The test will fail the assertion should be a remote frame

Looking at the logcat in automation for failure and a passing case, I see that in the passing test (with the isolateEverything strategy) there is a lot more logs comparing to the failing cases, and one important difference seems to be the presence of this log in the passing tests:

08-18 19:35:33.519  1657  2041 I ActivityManager: Start proc 5798:org.mozilla.geckoview.test_runner:tab26/u0a62 for service org.mozilla.geckoview.test_runner/org.mozilla.gecko.process.GeckoChildProcessServices$tab26
08-18 19:35:33.521  4171  4198 D ServiceAllocator: org.mozilla.gecko.process.GeckoChildProcessServices$tab26 updateBindings: FOREGROUND priority, 0 importance, 3 successful binds, 0 failed binds, 0 successful unbinds

The above doesn't happen in the failing tests.

Comment 1

[[:owlish] 🦉 PST]

I suspect https://bugzilla.mozilla.org/show_bug.cgi?id=1850440 might be a dupe of this one, or at least related. For now I don't dupe them for tracking purposes.

Comment 2

[Nika Layzell [:nika] (ni? for response)]

I expect that like the other test failures, this one is caused by the code incorrectly assuming the isolateEverything process isolation behaviour. The check here: https://searchfox.org/mozilla-central/rev/ddb4ab256d0e0a6bad3cbefa93546656284fa472/docshell/test/mochitest/test_iframe_srcdoc_to_remote.html#26 should probably not be made for isolateNothing, and for isolateHighValue it can either be done with http://example.net made high-value for the duration of the test, or it could be skipped in that scenario as well.

Comment 3

[[:owlish] 🦉 PST]

Attachment: Bug 1850429 - Adjust the test to make assertion on remote frame only for isolateEverything Fission site isolation strategy

Depends on D187073

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a44f3bb9cc1c
Adjust the test to make assertion on remote frame only for isolateEverything Fission site isolation strategy r=nika

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/a44f3bb9cc1c