1850440 - Fix test_blockBFCache.html test with isolateNothing and isolateHighValue strategies

Status: RESOLVED FIXED

(GeckoView Graveyard :: Sandboxing, task, P1)

Description

[[:owlish] 🦉 PST]

STR:

• Run docshell/test/navigation/test_blockBFCache.html on any Android Fission build with isolateNothing or isolateHighValue strategy (set fission.webContentIsolationStrategy to 0 or 2 respectively).
• The test will fail the assertion Page should have been blocked from going into the BFCache (Loading OOP iframe)

Looking at the logcat in automation for failure and for passing case, I see that in the passing test has this log:

08-18 19:31:11.732  1659  1670 I ActivityManager: Start proc 3866:org.mozilla.geckoview.test_runner:tab33/u0a62 for service org.mozilla.geckoview.test_runner/org.mozilla.gecko.process.GeckoChildProcessServices$tab33
08-18 19:31:11.734  3536  3564 D ServiceAllocator: org.mozilla.gecko.process.GeckoChildProcessServices$tab33 updateBindings: FOREGROUND priority, 0 importance, 3 successful binds, 0 failed binds, 0 successful unbinds

The above doesn't happen in the failing tests.

Comment 1

[Nika Layzell [:nika] (ni? for response)]

In this case, I think the failure is somewhat expected. The check here: https://searchfox.org/mozilla-central/rev/ddb4ab256d0e0a6bad3cbefa93546656284fa472/docshell/test/navigation/test_blockBFCache.html#101, should probably have been made to reject isolateNothing, and either not run with isolateHighValue, or to temporarily make https://example.com be a high-value origin for the duration of the test.

Comment 2

[[:owlish] 🦉 PST]

Attachment: Bug 1850440 - Adjust the test to make assertion on remote frame only for isolateEverything Fission site isolation strategy

Depends on D187154

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f4adf6b8b7f1
Adjust the test to make assertion on remote frame only for isolateEverything Fission site isolation strategy r=nika

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/f4adf6b8b7f1