1850587 - Remote frames and proxies in Android Fission isolateNothing & isolateHighValue

Status: RESOLVED FIXED

(GeckoView Graveyard :: Sandboxing, task, P1)

Description

[[:owlish] 🦉 PST]

Tests and assertions affected:

• TEST-UNEXPECTED-FAIL | js/xpconnect/tests/mochitest/test_isRemoteProxy.html | frames[1] is a remote proxy if Fission is enabled - got false, expected true
• TEST-UNEXPECTED-FAIL | js/xpconnect/tests/mochitest/test_isRemoteProxy.html | frames[1].location is a remote proxy if Fission is enabled - got false, expected true
• TEST-UNEXPECTED-FAIL | dom/bindings/test/test_remoteProxyAsPrototype.html | win is a remote proxy if Fission is enabled - got false, expected true

when run on any Android build with Fission enabled and fission.webContentIsolationStrategy set to 0 or 2.

I compared the log for failure and success (with isolateEverything strategy) and one difference is the presence of these in the success logs:

08-18 19:55:36.293  1659  2101 I ActivityManager: Start proc 28537:org.mozilla.geckoview.test_runner:tab35/u0a62 for service org.mozilla.geckoview.test_runner/org.mozilla.gecko.process.GeckoChildProcessServices$tab35
08-18 19:55:36.295 27549 27576 D ServiceAllocator: org.mozilla.gecko.process.GeckoChildProcessServices$tab35 updateBindings: FOREGROUND priority, 0 importance, 3 successful binds, 0 failed binds, 0 successful unbinds

This bug might be related (or maybe even a dupe) to others (see in See Also)

Comment 1

[Nika Layzell [:nika] (ni? for response)]

It is somewhat expected that this will fail with these isolation strategies as the code is effectively testing the process allocaiton behaviour of isolateEverything - so the processes won't be remote if isolateNothing or isolateHighValue are selected, meaning the tests will fail.

The logic here: https://searchfox.org/mozilla-central/rev/ddb4ab256d0e0a6bad3cbefa93546656284fa472/js/xpconnect/tests/mochitest/test_isRemoteProxy.html#44-49, should be changed to only expect the value to be true if fission is enabled, and webContentIsolationStrategy is isolateEverything. Same deal with https://searchfox.org/mozilla-central/rev/ddb4ab256d0e0a6bad3cbefa93546656284fa472/dom/bindings/test/test_remoteProxyAsPrototype.html#19.

Comment 2

[[:owlish] 🦉 PST]

Thank you Nika! I'll adjust the expectations of these tests

Comment 3

[[:owlish] 🦉 PST]

Attachment: Bug 1850587 - Adjust expectations for the tests to account for isolation strategy in Fission

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ddf5a96b8817
Adjust expectations for the tests to account for isolation strategy in Fission r=nika

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/ddf5a96b8817