Closed Bug 1850800 Opened 1 year ago Closed 1 year ago

Ctrl+Shift+T sometimes reopens closed windows instead of the last closed tab

Categories

(Firefox :: Session Restore, defect)

defect

Tracking

()

RESOLVED INVALID

People

(Reporter: rkraesig, Unassigned)

References

Details

Steps to reproduce:

  1. Open a new Fx window ("window A").
  2. Open a new Fx window ("window B"). Go to data:text/html,<body bgcolor=green>.
  3. In Window B, open a new tab. Go to data:text/html,<body bgcolor=darkred>.
  4. Open a new Fx window ("window C"). Go to data:text/html,<body bgcolor=magenta>.
  5. In Window C, open a new tab. Go to data:text/html,<body bgcolor=blue>.
  6. Close window A.
  7. Close the darkred tab in window B.
  8. Close the blue tab in window C.
  9. Bring window B (green) back in focus. Press Ctrl+Shift+T. The darkred tab will reappear.
  10. Bring window C (magenta) back in focus. Press Ctrl+Shift+T.

Expected behavior: the blue tab reopens.

Actual behavior: Window A will reopen.

This is similar to, but distinct from, bug 1839093.

NONONO it's a feature!!! Check changelog!!! (Section "Changed) https://www.mozilla.org/en-US/firefox/116.0/releasenotes/

Status: NEW → RESOLVED
Closed: 1 year ago
Flags: needinfo?(rkraesig)
Resolution: --- → WORKSFORME
Status: RESOLVED → UNCONFIRMED
Ever confirmed: false
Resolution: WORKSFORME → ---

Ooooh nevermind, sorry, I just realized it is a super complicated (and probably very rare) bug you discovered. Apologies.

Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: needinfo?(rkraesig)

Yes, I'm aware of the feature. (Or I'm aware now, anyway. It did slip past me at the time.)

As an aside, though, I would also recommend reverting it, because the new behavior — as specified, I mean, not just with the bug — explicitly breaks locality in very surprising ways if you're the sort of user who uses multiple windows and multiple tabs-per-window. In particular, per bug 1833416's title, the "expected" behavior in step 9 would be to restore the blue tab first despite its window not being in focus. I would be very surprised to learn that that's what most users would actually want!

I can definitely see it being useful to have a generic global undo operation for this sort of thing (the discussion in bug 1850616 may perhaps also provide a motivating example?), but I don't think it was a good idea to subvert the existing meaning of Ctrl+Shift+T in this way.

(Also moving to Firefox :: Session Restore, where the previous bugs were; mea culpa. Though perhaps Firefox :: Keyboard Navigation would be more appropriate?)

Component: Bookmarks & History → Session Restore
Flags: needinfo?(sclements)

Hi, I'm not able to reproduce. This might have been fixed by some additional bug fixes in this area (and Window A shouldn't actually ever reopen if the only tab open is new tab - there was an inconsistency that was fixed recently in bug 1847617). I'm going to close this out, but if you are seeing the same bug please reopen this (note: we do not revert features upon request, please only use this forum for actual bugs).

Status: NEW → RESOLVED
Closed: 1 year ago1 year ago
Flags: needinfo?(sclements)
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.