1851447 - Add search for recent browsing

Status: VERIFIED FIXED

(Firefox :: Firefox View, enhancement, P1)

Description

[Sarah Clements [:sclements]]

Search all of the data present on the page (in-page search only), and an input added per the figma spec.

Comment 1

[Jonathan Sudiaman [:jsudiaman]]

Attachment: Bug 1851447 - Add search for recent browsing r?#fxview-reviewers

Comment 2

[Eric Pang [:epang] UX]

I've updated the specs to reflect that we will show 5 search results per section at a time. There is a "Show all" button that can be pressed to see the rest of the results. https://www.figma.com/file/wP9MY9KJn9xqPf140lTvTv/Fx-View-Specs-2023?type=design&node-id=6372%3A186180&mode=design&t=nXJGIal7TcdHMNi0-1

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/543445fb01a8
Add search for recent browsing r=fxview-reviewers,fluent-reviewers,flod,sclements,kcochrane

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/543445fb01a8

Comment 5

[Daniel Bodea [:danibodea]]

Are there any conditions for this search bar to appear in the tabs of Firefox View?
It is displayed and functioning in Nigfhtly v123.0a1, but it would not be displayed in Beta v122.0b1 and v122.0b2. Is that intended?

Comment 6

[Jonathan Sudiaman [:jsudiaman]]

(In reply to Daniel Bodea [:danibodea] from comment #5)

Are there any conditions for this search bar to appear in the tabs of Firefox View?
It is displayed and functioning in Nigfhtly v123.0a1, but it would not be displayed in Beta v122.0b1 and v122.0b2. Is that intended?

User must enable browser.firefox-view.search.enabled in about:config in order for the search bar to appear. This preference will be enabled by default in Firefox 123.

Comment 7

[Daniel Bodea [:danibodea]]

I can confirm the appearance and functionality of the search bar in the Firefox View Recent Browsing section. Tested in Windows 10, Windows 11, MacOS 11 and Ubuntu 22 using Firefox Release v122.0.1, Beta v123.0 (RC) and Nightly v124.0a1. It is displayed by default in branch 124 and 123, but needs to be activated manually in branch 122. Thank you.