Closed Bug 1851941 Opened 9 months ago Closed 9 months ago

Add UTM params to addon suggestion URLs

Categories

(Firefox :: Address Bar, task, P1)

task

Tracking

()

VERIFIED FIXED
119 Branch
Tracking Status
firefox118 --- verified
firefox119 --- verified

People

(Reporter: adw, Assigned: adw)

References

Details

Attachments

(1 file)

utm_medium: "firefox-desktop",
utm_source: "firefox-suggest",

Depends on D187640

Pushed by dwillcoxon@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/609dbaf50b6f
Add UTM params to addon suggestion URLs. r=daisuke
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → 119 Branch

STR for QA:

  1. Enable Firefox Suggest: browser.urlbar.quicksuggest.enabled = true
  2. Type any addon keyword, for example videos
  3. Verify the URL shown in the suggestion contains utm_medium=firefox-desktop&utm_source=firefox-suggest parameters at the end
  4. Click the suggestion and verify the loaded URL contains the same parameters
Flags: qe-verify+
Flags: in-testsuite+

Comment on attachment 9351936 [details]
Bug 1851941 - Add UTM params to addon suggestion URLs.

Beta/Release Uplift Approval Request

  • User impact if declined: We'd like to ship this feature (addon suggestions in the urlbar) in 118.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: Please see earlier comment
  • List of other uplifts needed: These 3 bugs need to be uplifted in the following order: bug 1851940, bug 1851941 (this bug), bug 1851942
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): This patch only adds some UTM parameters to the URLs of addon suggestions in the urlbar.
  • String changes made/needed:
  • Is Android affected?: No
Attachment #9351936 - Flags: approval-mozilla-beta?

Comment on attachment 9351936 [details]
Bug 1851941 - Add UTM params to addon suggestion URLs.

Approved for 118.0b7, thanks.

Attachment #9351936 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
QA Whiteboard: [qa-triaged]

Verified on Nightly 119.0a1 (2023-09-07) with details in 1852329#c1.

Verified as fixed with Firefox 118.0b7 on Windows 10, Mac 13, Ubuntu 22. Further smoke testing will be performed and reported in bug 1852329.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: