1851941 - Add UTM params to addon suggestion URLs

Status: VERIFIED FIXED

(Firefox :: Address Bar, task, P1)

Description

[Drew Willcoxon :adw]

utm_medium: "firefox-desktop",
utm_source: "firefox-suggest",

Comment 1

[Drew Willcoxon :adw]

Attachment: Bug 1851941 - Add UTM params to addon suggestion URLs.

Depends on D187640

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/609dbaf50b6f
Add UTM params to addon suggestion URLs. r=daisuke

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/609dbaf50b6f

Comment 4

[Drew Willcoxon :adw]

STR for QA:

1. Enable Firefox Suggest: browser.urlbar.quicksuggest.enabled = true
2. Type any addon keyword, for example videos
3. Verify the URL shown in the suggestion contains utm_medium=firefox-desktop&utm_source=firefox-suggest parameters at the end
4. Click the suggestion and verify the loaded URL contains the same parameters

Comment 5

[Drew Willcoxon :adw]

Comment on attachment 9351936 [details]
Bug 1851941 - Add UTM params to addon suggestion URLs.

Beta/Release Uplift Approval Request

• User impact if declined: We'd like to ship this feature (addon suggestions in the urlbar) in 118.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Please see earlier comment
• List of other uplifts needed: These 3 bugs need to be uplifted in the following order: bug 1851940, bug 1851941 (this bug), bug 1851942
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This patch only adds some UTM parameters to the URLs of addon suggestions in the urlbar.
• String changes made/needed:
• Is Android affected?: No

Comment 6

[Pascal Chevrel:pascalc]

Comment on attachment 9351936 [details]
Bug 1851941 - Add UTM params to addon suggestion URLs.

Approved for 118.0b7, thanks.

Comment 7

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/99eb92d8515f

Comment 8

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/99eb92d8515f

Comment 9

[Adrian Florinescu [:aflorinescu]]

Verified on Nightly 119.0a1 (2023-09-07) with details in 1852329#c1.

Comment 10

[Ardelean Oana, Desktop QA [:oardelean]]

Verified as fixed with Firefox 118.0b7 on Windows 10, Mac 13, Ubuntu 22. Further smoke testing will be performed and reported in bug 1852329.