Closed
Bug 1851942
Opened 1 years ago
Closed 1 years ago
Update the "Not relevant" command for addon suggestions to block individual suggestions
Categories
(Firefox :: Address Bar, task, P1)
Firefox
Address Bar
Tracking
()
VERIFIED
FIXED
119 Branch
People
(Reporter: adw, Assigned: adw)
References
Details
Attachments
(1 file)
48 bytes,
text/x-phabricator-request
|
pascalc
:
approval-mozilla-beta+
|
Details | Review |
"Not relevant" should block individual suggestions instead of disabling the addon suggestions feature.
Assignee | ||
Comment 1•1 years ago
|
||
Depends on D187642
Pushed by dwillcoxon@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d6053b12dda2
Update the "Not relevant" command for addon suggestions to block individual suggestions. r=daisuke
Comment 3•1 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 1 years ago
status-firefox119:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 119 Branch
Assignee | ||
Comment 4•1 years ago
|
||
STR for QA:
Key points:
- The "Not relevant" command should dismiss an individual suggestion and not show it again
- The "Not interested" command should dismiss all addon suggestions and not show them again
STR:
- Enable Firefox Suggest:
browser.urlbar.quicksuggest.enabled
= true - Type any addon keyword, for example
videos
- Click the Feedback menu > Don't show this > Not relevant
- Verify the suggestion is replaced with the message: "Thanks for your feedback. You won't see this suggestion again."
- Click the "Got it" button and verify the message goes away
- Type the same keyword again from step 2 and verify the suggestion does not appear
- Type a different addons keyword, for example
typo
- Verify a different addon suggestion appears
- Click the Feedback menu > Don't show this > Not interested (note this is a different command from step 3)
- Verify the suggestion is replaced with the message: "Thanks for your feedback. You won't see these suggestions anymore."
- Click the "Got it" button and verify the message goes away
- Type the same two keywords you used in the previous steps and verify the suggestions do not appear
- Type a new addon keyword, for example
tts
- Verify the addon suggestion does not appear
Flags: qe-verify+
Flags: in-testsuite+
Assignee | ||
Comment 5•1 years ago
|
||
Comment on attachment 9351938 [details]
Bug 1851942 - Update the "Not relevant" command for addon suggestions to block individual suggestions.
Beta/Release Uplift Approval Request
- User impact if declined: We'd like to ship this feature (addon suggestions in the urlbar) in 118.
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: Please see earlier comment
- List of other uplifts needed: These 3 bugs need to be uplifted in the following order: bug 1851940, bug 1851941, bug 1851942 (this bug)
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): This changes the behavior of a context menu command for addon suggestions in the urlbar. It only affects addon suggestions.
- String changes made/needed:
- Is Android affected?: No
Attachment #9351938 -
Flags: approval-mozilla-beta?
Comment 6•1 years ago
|
||
Comment on attachment 9351938 [details]
Bug 1851942 - Update the "Not relevant" command for addon suggestions to block individual suggestions.
Approved for 118.0b7, thanks.
Attachment #9351938 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 8•1 years ago
|
||
bugherder uplift |
status-firefox118:
--- → fixed
Updated•1 years ago
|
QA Whiteboard: [qa-triaged]
Comment 9•1 years ago
|
||
Verified on Nightly 119.0a1 (2023-09-07) with details in 1852329#c1.
Verified as fixed with Firefox 118.0b7 on Windows 10, Mac 13, Ubuntu 22. Further smoke testing will be performed and reported in bug 1852329.
You need to log in
before you can comment on or make changes to this bug.
Description
•