1851942 - Update the "Not relevant" command for addon suggestions to block individual suggestions

Status: VERIFIED FIXED

(Firefox :: Address Bar, task, P1)

Description

[Drew Willcoxon :adw]

"Not relevant" should block individual suggestions instead of disabling the addon suggestions feature.

Comment 1

[Drew Willcoxon :adw]

Attachment: Bug 1851942 - Update the "Not relevant" command for addon suggestions to block individual suggestions.

Depends on D187642

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d6053b12dda2
Update the "Not relevant" command for addon suggestions to block individual suggestions. r=daisuke

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/d6053b12dda2

Comment 4

[Drew Willcoxon :adw]

STR for QA:

Key points:

• The "Not relevant" command should dismiss an individual suggestion and not show it again
• The "Not interested" command should dismiss all addon suggestions and not show them again

STR:

1. Enable Firefox Suggest: browser.urlbar.quicksuggest.enabled = true
2. Type any addon keyword, for example videos
3. Click the Feedback menu > Don't show this > Not relevant
4. Verify the suggestion is replaced with the message: "Thanks for your feedback. You won't see this suggestion again."
5. Click the "Got it" button and verify the message goes away
6. Type the same keyword again from step 2 and verify the suggestion does not appear
7. Type a different addons keyword, for example typo
8. Verify a different addon suggestion appears
9. Click the Feedback menu > Don't show this > Not interested (note this is a different command from step 3)
10. Verify the suggestion is replaced with the message: "Thanks for your feedback. You won't see these suggestions anymore."
11. Click the "Got it" button and verify the message goes away
12. Type the same two keywords you used in the previous steps and verify the suggestions do not appear
13. Type a new addon keyword, for example tts
14. Verify the addon suggestion does not appear

Comment 5

[Drew Willcoxon :adw]

Comment on attachment 9351938 [details]
Bug 1851942 - Update the "Not relevant" command for addon suggestions to block individual suggestions.

Beta/Release Uplift Approval Request

• User impact if declined: We'd like to ship this feature (addon suggestions in the urlbar) in 118.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Please see earlier comment
• List of other uplifts needed: These 3 bugs need to be uplifted in the following order: bug 1851940, bug 1851941, bug 1851942 (this bug)
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This changes the behavior of a context menu command for addon suggestions in the urlbar. It only affects addon suggestions.
• String changes made/needed:
• Is Android affected?: No

Comment 6

[Pascal Chevrel:pascalc]

Comment on attachment 9351938 [details]
Bug 1851942 - Update the "Not relevant" command for addon suggestions to block individual suggestions.

Approved for 118.0b7, thanks.

Comment 7

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/68a05148e915

Comment 8

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/68a05148e915

Comment 9

[Adrian Florinescu [:aflorinescu]]

Verified on Nightly 119.0a1 (2023-09-07) with details in 1852329#c1.

Comment 10

[Ardelean Oana, Desktop QA [:oardelean]]

Verified as fixed with Firefox 118.0b7 on Windows 10, Mac 13, Ubuntu 22. Further smoke testing will be performed and reported in bug 1852329.