1852354 - For addon and Pocket suggestions, the “Show less frequently” option is not removed from the Feedback menu if the Address Bar panel is not closed after reaching the frequency cap

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Drew Willcoxon :adw]

If you keep clicking "Show less frequently" on an addon suggestion until the cap is reached without closing the urlbar panel, the command should disappear from the menu but it doesn't. This bug isn't possible to trigger right now due to the fact there is no cap (bug 1852353).

This is the same as bug 1832826 except for addon suggestions, and the fix is the same.

Comment 1

[Drew Willcoxon :adw]

Happens with Pocket suggestions too. I don't think we need a separate bug so morphing this one to include them.

Comment 2

[Drew Willcoxon :adw]

Attachment: Bug 1852354 - Invalidate the result menu command cache on "Show less frequently" for addon and Pocket suggestions.

It isn't possible to manually test this right now until we set a cap in the
remote settings config (bug 1852353), but the automated tests cover it.

Depends on D187830

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a04c14371715
Invalidate the result menu command cache on "Show less frequently" for addon and Pocket suggestions. r=daisuke

Comment 4

[Drew Willcoxon :adw]

STR for QA

1. Enable Firefox Suggest: browser.urlbar.quicksuggest.enabled = true
2. Type a keyword to trigger an addon suggestion, like tts
3. In the suggestion, click the Feedback menu > Show less frequently
4. Without closing the urlbar panel, repeat the previous step two more times, for a total of 3 times
5. Open the Feedback menu and verify "Show less frequently" doesn't appear anymore

Please enable Pocket suggestions and repeat the STR.

• To enable Pocket: browser.urlbar.pocket.featureGate = true
• Example Pocket keyword: breakfast

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/a04c14371715

Comment 6

[Drew Willcoxon :adw]

Comment on attachment 9352332 [details]
Bug 1852354 - Invalidate the result menu command cache on "Show less frequently" for addon and Pocket suggestions.

Beta/Release Uplift Approval Request

• User impact if declined: This is a fix to a minor problem for the initial release of addon suggestions in the address bar. It would be nice to fix as part of the initial release.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Please see previous comment
• List of other uplifts needed: Bug 1852300
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is a small patch that affects non-core functionality of addon and Pocket suggestions in the address bar. Only addon suggestions are enabled by default (starting in 118), and they are only enabled for U.S. users. The patch has tests.
• String changes made/needed:
• Is Android affected?: No

Comment 7

[Pascal Chevrel:pascalc]

Comment on attachment 9352332 [details]
Bug 1852354 - Invalidate the result menu command cache on "Show less frequently" for addon and Pocket suggestions.

Approved for 118.0b9 (last beta) thanks.

Comment 8

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/73b7fc5f26f5

Comment 9

[Adrian Florinescu [:aflorinescu]]

Verified as fixed with 118.0b9 (treeherder), 119.0a1 (2023-09-13) on Windows 10, Ubuntu 22, Mac 13.