1881073 - The “Show less frequently” option is not removed from the Feedback menu if the Address Bar panel is not closed after clicking it more times than the set cap value

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Carmen Fat [:cfat] - Ecosystem QA]

[Affected versions]:

• Firefox Nightly 125.0a1 - Build ID: 20240220094730
• Firefox Beta 124.0b1 - Build ID: 20240219092531

[Affected Platforms]:

• Windows 10 x64
• macOS 12.6.1
• Linux Ubuntu 20.04 x64

[Prerequisites]:

• Have the following prefs set with the values to enable the feature:
  browser.search.region = US (connect to a VPN server if outside the US)
  nimbus.debug = true
• Switch to the Stage server using the Remote Settings Devtools addon.

[Steps to reproduce]:

1. Open the browser with the profile from the prerequisites.
2. Copy and paste the following link in order to force enroll in the Yelp suggestions experiment:
   about:studies?optin_slug=qa-2280-yelp-suggestions-qa&optin_branch=treatment-suggest&optin_collection=nimbus-preview
3. Restart the browser.
4. Type the “arcade” string in the Address Bar.
5. Click the “Feedback” button from the Yelp suggestion.
6. Click the “Show less frequently” option.
7. Repeat steps 5 and 6 for at least 2 more times.
8. Click the Feedback button.
9. Observe the menu options.

[Expected result]:

• The “Show less frequently” option is no longer available.

[Actual result]:

• The “Show less frequently” option remains displayed.

[Notes]:

• The browser.urlbar.yelp.showLessFrequentlyCount pref registers only one click when the Address Bar results panel is open. To register the next click, the user has to close the Address Bar results panel and then trigger the Yelp suggestion again.
• This issue affects Yelp results displayed on both Top Pick and Firefox Suggest locations.
• Here is a screen recording of the issue.

Comment 1

[Drew Willcoxon :adw]

Attachment: Bug 1881073 - Update Yelp suggestions "Show less frequently" behavior.

The problem is that show_less_frequently is misspelled. That doesn't cause the
first "Show less frequently" click to fail, but it does cause later clicks to
fail as long as the urlbar session remains ongoing (i.e., the view remains
open). That's because TelemetryEvent has a hardcoded check for
show_less_frequently when it determines whether the session is still ongoing.
This check fails due to the misspelling, so TelemetryEvent thinks the session
has ended, which messes up later events and commands.

This makes a few related improvements:

• Support the showLessFrequentlyCap in the remote settings config for Yelp
• Add a "Show less frequently" task to the Yelp test. This uses the existing
  doShowLessFrequentlyTests() helper, which requires the related getters
  and methods to be public.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9ed80152b595
Fix Yelp suggestions "Show less frequently" behavior. r=daisuke

Comment 3

[Cristina Horotan [:chorotan]]

Backed out on request

Backout: https://hg.mozilla.org/integration/autoland/rev/2fa632f82ed1de0ba2ae7057da10e029baa1eccd

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ed817c8c33cd
Update Yelp suggestions "Show less frequently" behavior. r=daisuke

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/ed817c8c33cd

Comment 6

[Carmen Fat [:cfat] - Ecosystem QA]

I have verified this issue on the latest Firefox Nightly 125.0a1 (Build ID: 20240222100216) on Windows 10 x64, Ubuntu 20.04 x64, and macOS 13.1.

• The “Show less frequently” option from the Yelp suggestion Feedback menu is not displayed anymore once the frequency cap is hit.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:adw, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox124 to wontfix.

For more information, please visit BugBot documentation.

Comment 8

[Drew Willcoxon :adw]

Comment on attachment 9381876 [details]
Bug 1881073 - Update Yelp suggestions "Show less frequently" behavior.

Beta/Release Uplift Approval Request

• User impact if declined: This is necessary for the Yelp suggestions experiment that will target 124.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Should be clear from previous comments
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Only affects Yelp suggestions, which are disabled by default. Has tests.
• String changes made/needed:
• Is Android affected?: No

Comment 9

[Dianna Smith [:diannaS]]

Comment on attachment 9381876 [details]
Bug 1881073 - Update Yelp suggestions "Show less frequently" behavior.

Approved for 124.0b5

Comment 10

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/bae8bbcc673a

Comment 11

[Carmen Fat [:cfat] - Ecosystem QA]

I have verified this issue on the latest Firefox Beta 124.0b5 (Build ID: 20240228091714) on Windows 10 x64, Ubuntu 20.04 x64, and macOS 12.6.1.

• The “Show less frequently” option from the Yelp suggestion Feedback menu is not displayed anymore once the frequency cap is hit.