1852732 - Context menu items in preferences have no hover background color

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Martin Giger [:freaktechnik]]

Attachment: image.png

Regression range: https://hg.mozilla.org/comm-central/pushloghtml?fromchange=d0c328a2cc3340ab6f6458442ea89e366e33bd8e&tochange=6490fed4cf5c6d79aacd25442d7e6a14560c7878 (I suspect it's bug 1828413 )

And based on that bug I assume this affects Linux only.

The issue is caused by this rule: https://searchfox.org/comm-central/rev/621b473f53010d28dd3872693cd42f7a7a2dd61b/mail/themes/shared/mail/common.css#125

STR:

• Open Settings
• Go to privacy tab
• Open passwords dialog (saved passwords)
• Right click on any entry
• Hover over any activated menu item

Comment 1

[Martin Giger [:freaktechnik]]

Attachment: Bug 1852732 - Don't modify menu item background color. r=#thunderbird-front-end-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/eaf52b27ea0a
Don't modify menu item background color. r=aleca

Comment 3

[Martin Giger [:freaktechnik]]

Comment on attachment 9352645 [details]
Bug 1852732 - Don't modify menu item background color. r=#thunderbird-front-end-reviewers

[Approval Request Comment]
Regression caused by (bug #): probably bug 1828413
User impact if declined: Context menu items appear blank when hovered on some linux themes
Testing completed (on c-c, etc.): Manual testing on c-c
Risk to taking this patch (and alternatives if risky): Low risk, style change for menu items (though the change can affect any platform)

Comment 4

[Wayne Mery (:wsmwk)]

Comment on attachment 9352645 [details]
Bug 1852732 - Don't modify menu item background color. r=#thunderbird-front-end-reviewers

[Triage Comment]
Approved for beta

Comment 5

[Daniel Darnell [:dandarnell]]

Thunderbird 118.0b5:
https://hg.mozilla.org/releases/comm-beta/rev/768fa3b66dfd

Comment 6

[Martin Giger [:freaktechnik]]

Comment on attachment 9352645 [details]
Bug 1852732 - Don't modify menu item background color. r=#thunderbird-front-end-reviewers

[Approval Request Comment]
Regression caused by (bug #): bug 1828413
User impact if declined: Context menu items in settings (and possibly other places) can be unreadable when hovered
Testing completed (on c-c, etc.): Tested on c-c and beta 118.0b5
Risk to taking this patch (and alternatives if risky): low risk, small CSS change

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9352645 [details]
Bug 1852732 - Don't modify menu item background color. r=#thunderbird-front-end-reviewers

[Triage Comment]
Approved for esr115

Comment 8

[Daniel Darnell [:dandarnell]]

Thunderbird 115.3.0:
https://hg.mozilla.org/releases/comm-esr115/rev/2247d3b7966d