1852744 - customize unified toolbar - the cancel and Ok button is escape from the screen

Status: RESOLVED FIXED

(Thunderbird :: Toolbars and Tabs, defect)

Description

[Robert]

Attachment: TB102x.jpg

Steps to reproduce:

i upgrade few instances of TB [x64, pl-PL] 102.14.0/102.15.0 to TB [x64 pl-PL] 115.0/115.1.0/115.2.0/115.2.1 on Windows 10 (Pro) x64 22H2 pl-PL

Actual results:

for all of those I try to attach a screen shots.

I have ~200 machines with TB x64 102.14.0 (now 102.15.0).
I manually upgrade many of them to test 115.0 (now 115.2.1)
There where I can, i revert back changes (from backup) to 102.15.0

When upgrade was done, mainly the toolbars on main window was very messed up, and i cannot reorganize them as was previously...

• i cannot move hamburger menu to left side - is sticky some how to the right upper corner i don't know why :(
• the main menu is located under toolbar's, and cannot be moved back on top :(
• the free space on to tab bar is no longer available to allocate then icons by user (use as second toolbar), the icons that was there until 102.x was merged into main toolbar, and messed them up :(
• I no longer can use free space on the menu bar as another toolbar, and the icons from there is merged into main toolbar as tab bar :(
• the "Get Messages" button have lost their functionality - the down arrow located on the right side of icons, and now, I cannot in (simply way) select, witch account i want to get messages :(
• the "Forward" button is spited into 2 buttons - i think this is wasting a space to put them both on the toolbar. IMHO should be third option - as was until 102.x version (with arrow, where i simply can select that what i want to do)
• IMHO The numbers in folders lists, that describes total and unread messages are to small and unreadable for people with bad eyes. I known, that i can large this, but this is larges all others element :( Is there a way to this revert back to previously lookup - without rounded balloons ?
• customize toolbar - the cancel and Ok button is escape from the screen - (the right side)

Expected results:

• upgrading 102.x -> 115.x should not to mess up toolbar's customized by the user.
• menu bar should be able to move then up and tow - TB should allow to be on top or under toolbar's.
• Forward buttons - should be restored their functionality (as was until 102.15.0) for save the screen space for other buttons.
• Get messages button should allow to select in simply way - witch (or all) account i want to check/get new messages
• Ok and Cancel buttons should be visible into its window range, to allow to click them as needed.
• TB should allow to use free space for additional buttons onto the classic main menu bar and tabs bar as was until 102.15.0

Comment 1

[Robert]

upgrading to 115.x and the new version is also not respecting user settings in customization window - show icons and their description text below icon - in 115.x default is the text is near icons, not as user selected (icons with text below).

Comment 2

[Robert]

Attachment: tb115x-main_window_toolbar.jpg

main windows after upgrade 102.x->115.x

Comment 3

[Robert]

Attachment: tb115x-customization_windows.jpg

TB 115.x customization windows

Comment 4

[Magnus Melin [:mkmelin]]

One issue per bug report please. Some references: bug 1822991, bug 1837152.

Let's make this bug about the customization window overflowing. (I don't recall a bug report about that.)

Comment 5

[Robert]

OK, I understand.

Should I create few bug reports for above bugs ?

Comment 6

[Wayne Mery (:wsmwk)]

(In reply to Robert from comment #5)

Should I create few bug reports for above bugs ?

Yes, if they reproduce in troubleshoot mode

Comment 7

[Martin Giger [:freaktechnik]]

Attachment: Bug 1852744 - Fix toolbar customization contents overflowing window width. r=#thunderbird-front-end-reviewers

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e8bc201d0f0c
Fix toolbar customization contents overflowing window width. r=Paenglab

Comment 9

[Martin Giger [:freaktechnik]]

Comment on attachment 9379928 [details]
Bug 1852744 - Fix toolbar customization contents overflowing window width. r=#thunderbird-front-end-reviewers

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: Can overflow the toolbar customization such that it can only be quit with Escape or closing Thunderbird.
Testing completed (on c-c, etc.): Tested on c-c. Tested patch applies to esr115.
Risk to taking this patch (and alternatives if risky): Low risk, CSS change only.

Comment 10

[Wayne Mery (:wsmwk)]

Comment on attachment 9379928 [details]
Bug 1852744 - Fix toolbar customization contents overflowing window width. r=#thunderbird-front-end-reviewers

[Triage Comment]
Approved for esr115

Comment 11

[Daniel Darnell [:dandarnell]]

Thunderbird 115.8.1:
https://hg.mozilla.org/releases/comm-esr115/rev/7a34e1eb767b