1874206 - Implement basic support for "network.continueRequest" and "network.continueResponse"

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, task, P2)

Description

[Julian Descottes [:jdescottes]]

The goal of this bug is to add support for the network.continueRequest and network.continueResponse commands, but only for the mandatory request parameter. Support for all optional parameters will be deferred to Bug 1850680 and Bug 1853887.

This should be straightforward to implement.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1874206 - [bidi] Implement basic support for network.continueRequest

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1874206 - [bidi] Implement basic support for network.continueResponse

Depends on D199748

On top of request support, also add credentials support since we already have the underlying logic for continueWithAuth

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 1874206 - [wdspec] Update network test module with remaining arguments network.continueRequest

Depends on D199749

Comment 4

[Julian Descottes [:jdescottes]]

Attachment: Bug 1874206 - [wdspec] Add validation test for all remaining arguments of network.continueRequest

Depends on D199750

Comment 5

[Julian Descottes [:jdescottes]]

Attachment: Bug 1874206 - [wdspec] Update network test module with remaining arguments network.continueResponse

Depends on D199751

Comment 6

[Julian Descottes [:jdescottes]]

Attachment: Bug 1874206 - [wdspec] Add validation test for all remaining arguments of network.continueResponse

Depends on D199752

Comment 7

[Julian Descottes [:jdescottes]]

Attachment: Bug 1874206 - [wdspec] Add test for network.continueRequest

Depends on D199753

Comment 8

[Julian Descottes [:jdescottes]]

Attachment: Bug 1874206 - [wdspec] Add test for network.continueResponse

Depends on D199754

Comment 9

[Julian Descottes [:jdescottes]]

Attachment: Bug 1874206 - [wdspec] Add create_header and create_cookie_header helpers for bidi network tests

Depends on D199755

Adds test helpers to easily create header and cookie header objects

Comment 10

[Julian Descottes [:jdescottes]]

Attachment: Bug 1874206 - [remote] Add assert bytesValue helper to Assert module

Depends on D200034

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/af83a308059c
[bidi] Implement basic support for network.continueRequest r=webdriver-reviewers,Sasha
https://hg.mozilla.org/integration/autoland/rev/b6a19a176868
[bidi] Implement basic support for network.continueResponse r=webdriver-reviewers,Sasha
https://hg.mozilla.org/integration/autoland/rev/2e55faaccd82
[wdspec] Update network test module with remaining arguments network.continueRequest r=webdriver-reviewers,Sasha
https://hg.mozilla.org/integration/autoland/rev/e088bd5cef05
[wdspec] Add validation test for all remaining arguments of network.continueRequest r=webdriver-reviewers,Sasha
https://hg.mozilla.org/integration/autoland/rev/9636ddc3709a
[wdspec] Update network test module with remaining arguments network.continueResponse r=webdriver-reviewers,Sasha
https://hg.mozilla.org/integration/autoland/rev/cf600694c18f
[wdspec] Add validation test for all remaining arguments of network.continueResponse r=webdriver-reviewers,Sasha
https://hg.mozilla.org/integration/autoland/rev/c2eb34cf5007
[wdspec] Add test for network.continueRequest r=webdriver-reviewers,Sasha
https://hg.mozilla.org/integration/autoland/rev/3884f0a38e09
[wdspec] Add test for network.continueResponse r=webdriver-reviewers,Sasha
https://hg.mozilla.org/integration/autoland/rev/a3f956419067
[wdspec] Add create_header and create_cookie_header helpers for bidi network tests r=whimboo,webdriver-reviewers

Comment 12

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/44400 for changes under testing/web-platform/tests

Comment 13

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/af83a308059c
https://hg.mozilla.org/mozilla-central/rev/b6a19a176868
https://hg.mozilla.org/mozilla-central/rev/2e55faaccd82
https://hg.mozilla.org/mozilla-central/rev/e088bd5cef05
https://hg.mozilla.org/mozilla-central/rev/9636ddc3709a
https://hg.mozilla.org/mozilla-central/rev/cf600694c18f
https://hg.mozilla.org/mozilla-central/rev/c2eb34cf5007
https://hg.mozilla.org/mozilla-central/rev/3884f0a38e09
https://hg.mozilla.org/mozilla-central/rev/a3f956419067

Comment 14

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/af83a308059c
https://hg.mozilla.org/mozilla-central/rev/b6a19a176868
https://hg.mozilla.org/mozilla-central/rev/2e55faaccd82
https://hg.mozilla.org/mozilla-central/rev/e088bd5cef05
https://hg.mozilla.org/mozilla-central/rev/9636ddc3709a
https://hg.mozilla.org/mozilla-central/rev/cf600694c18f
https://hg.mozilla.org/mozilla-central/rev/c2eb34cf5007
https://hg.mozilla.org/mozilla-central/rev/3884f0a38e09
https://hg.mozilla.org/mozilla-central/rev/a3f956419067

Comment 15

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot